From: Andrew Cagney <ac131313@ges.redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Call FRAME_INIT_SAVED_REGS instead of mips_find_saved_regs
Date: Thu, 08 Aug 2002 21:19:00 -0000 [thread overview]
Message-ID: <3D5342DC.7060500@ges.redhat.com> (raw)
In-Reply-To: <1020809001129.ZM26138@localhost.localdomain>
> In the course of multiarching FRAME_INIT_SAVED_REGS, I did consider
> adding the necessary bits of code for setting
> frame->saved_regs[SP_REGNUM] in mips_find_saved_regs, but decided it
> would be more obvious if I did a straightforward translation of the
> (now replaced) macro. The elimination of mips_find_saved_regs() can
> wait for another day. After this patch though, there'll only be one
> caller, so it'll be easier to merge mips_find_saved_regs into
> mips_frame_init_saved_regs().
Can you please add a comment to mips_find_saved_regs() indicating this.
Otherwize approved.
Andrew
next prev parent reply other threads:[~2002-08-09 4:19 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-08 17:11 Kevin Buettner
2002-08-08 21:19 ` Andrew Cagney [this message]
2002-08-09 13:37 ` Kevin Buettner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D5342DC.7060500@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox