From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 25155 invoked by alias); 9 Aug 2002 04:19:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 25148 invoked from network); 9 Aug 2002 04:19:46 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 9 Aug 2002 04:19:46 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id D10FC3F77; Fri, 9 Aug 2002 00:19:40 -0400 (EDT) Message-ID: <3D5342DC.7060500@ges.redhat.com> Date: Thu, 08 Aug 2002 21:19:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Call FRAME_INIT_SAVED_REGS instead of mips_find_saved_regs References: <1020809001129.ZM26138@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00208.txt.bz2 > In the course of multiarching FRAME_INIT_SAVED_REGS, I did consider > adding the necessary bits of code for setting > frame->saved_regs[SP_REGNUM] in mips_find_saved_regs, but decided it > would be more obvious if I did a straightforward translation of the > (now replaced) macro. The elimination of mips_find_saved_regs() can > wait for another day. After this patch though, there'll only be one > caller, so it'll be easier to merge mips_find_saved_regs into > mips_frame_init_saved_regs(). Can you please add a comment to mips_find_saved_regs() indicating this. Otherwize approved. Andrew