From: Andrew Cagney <ac131313@ges.redhat.com>
To: Richard.Earnshaw@arm.com
Cc: Eli Zaretskii <eliz@is.elta.co.il>,
Michael Snyder <msnyder@redhat.com>,
gdb-patches@sources.redhat.com
Subject: Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin
Date: Wed, 07 Aug 2002 10:55:00 -0000 [thread overview]
Message-ID: <3D515F08.90005@ges.redhat.com> (raw)
In-Reply-To: <200208071543.QAA26484@cam-mail2.cambridge.arm.com>
>>
>> On Mon, 5 Aug 2002, Michael Snyder wrote:
>>
>
>> > do we actually know of any environments
>> > where the #if is strictly necessary?
>
>>
>> Since GDB requires ISO C, and "wb" is part of the ISO C spec, I think we
>> can drop the #if. (Dependance on O_BINARY being defined is not very
>> clean anyway, IMHO, since O_BINARY does not belong to `fopen'.)
>>
>
>
> I don't think we can assume an ISO conforming C library.
True. However, I think we should at least start out with the assumption
that the above will work. We should wait until someone presents us with
hard evidence that there is a problem before hacking around it :-)
enjoy,
Andrew
next prev parent reply other threads:[~2002-08-07 17:55 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-05 3:27 Corinna Vinschen
2002-08-05 5:30 ` Andreas Schwab
2002-08-05 16:10 ` Michael Snyder
2002-08-05 21:45 ` Eli Zaretskii
2002-08-06 1:10 ` Corinna Vinschen
2002-08-06 9:12 ` Eli Zaretskii
2002-08-07 1:52 ` Corinna Vinschen
2002-08-06 7:02 ` Andrew Cagney
2002-08-07 8:45 ` Richard Earnshaw
2002-08-07 10:55 ` Andrew Cagney [this message]
2002-08-07 22:09 ` Eli Zaretskii
2002-08-08 9:57 ` Andrew Cagney
2002-08-09 2:19 ` [RFA]: Change all fopen modes to binary in cli-dump.c [was Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin] Corinna Vinschen
2002-08-09 7:46 ` Andrew Cagney
2002-08-09 9:36 ` Corinna Vinschen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D515F08.90005@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=Richard.Earnshaw@arm.com \
--cc=eliz@is.elta.co.il \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox