From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13166 invoked by alias); 7 Aug 2002 17:55:49 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13065 invoked from network); 7 Aug 2002 17:55:21 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 7 Aug 2002 17:55:21 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 0D3153E9C; Wed, 7 Aug 2002 13:55:21 -0400 (EDT) Message-ID: <3D515F08.90005@ges.redhat.com> Date: Wed, 07 Aug 2002 10:55:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com Cc: Eli Zaretskii , Michael Snyder , gdb-patches@sources.redhat.com Subject: Re: [RFA] cli/cli-dump.c: Write dump always in binary mode on Cygwin References: <200208071543.QAA26484@cam-mail2.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-08/txt/msg00166.txt.bz2 >> >> On Mon, 5 Aug 2002, Michael Snyder wrote: >> > >> > do we actually know of any environments >> > where the #if is strictly necessary? > >> >> Since GDB requires ISO C, and "wb" is part of the ISO C spec, I think we >> can drop the #if. (Dependance on O_BINARY being defined is not very >> clean anyway, IMHO, since O_BINARY does not belong to `fopen'.) >> > > > I don't think we can assume an ISO conforming C library. True. However, I think we should at least start out with the assumption that the above will work. We should wait until someone presents us with hard evidence that there is a problem before hacking around it :-) enjoy, Andrew