From: Andrew Cagney <ac131313@ges.redhat.com>
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-n32 use_struct_convention
Date: Tue, 06 Aug 2002 14:26:00 -0000 [thread overview]
Message-ID: <3D503EF6.9080902@ges.redhat.com> (raw)
In-Reply-To: <3D49EB9E.3A59088D@redhat.com>
> *************** show_mask_address (char *cmd, int from_t
> *** 561,570 ****
> int
> mips_use_struct_convention (int gcc_p, struct type *type)
> {
> ! if (MIPS_EABI)
> return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE);
> else
> ! return 1; /* Structures are returned by ref in extra arg0 */
> }
>
> /* Tell if the program counter value in MEMADDR is in a MIPS16 function. */
> --- 570,579 ----
> int
> mips_use_struct_convention (int gcc_p, struct type *type)
> {
> ! if (MIPS_EABI || MIPS_NEWABI)
> return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE);
> else
> ! return 1; /* Old ABI: structures are returned by ref in extra arg0 */
> }
>
Rather than doing this, can you please create two functions --- one for
each case --- and then update mips_gdbarch_init() accordingly.
Andrew
next prev parent reply other threads:[~2002-08-06 21:26 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-08-01 19:35 Michael Snyder
2002-08-06 14:26 ` Andrew Cagney [this message]
2002-08-06 14:49 ` Michael Snyder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3D503EF6.9080902@ges.redhat.com \
--to=ac131313@ges.redhat.com \
--cc=gdb-patches@sources.redhat.com \
--cc=msnyder@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox