From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-17390-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 6652 invoked by alias); 6 Aug 2002 21:26:17 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 6645 invoked from network); 6 Aug 2002 21:26:16 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 6 Aug 2002 21:26:16 -0000
Received: from ges.redhat.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id F372E3CB0; Tue,  6 Aug 2002 17:26:14 -0400 (EDT)
Message-ID: <3D503EF6.9080902@ges.redhat.com>
Date: Tue, 06 Aug 2002 14:26:00 -0000
From: Andrew Cagney <ac131313@ges.redhat.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020802
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Michael Snyder <msnyder@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips-n32 use_struct_convention
References: <3D49EB9E.3A59088D@redhat.com>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-08/txt/msg00140.txt.bz2

> *************** show_mask_address (char *cmd, int from_t
> *** 561,570 ****
>   int
>   mips_use_struct_convention (int gcc_p, struct type *type)
>   {
> !   if (MIPS_EABI)
>       return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE);
>     else
> !     return 1;			/* Structures are returned by ref in extra arg0 */
>   }
>   
>   /* Tell if the program counter value in MEMADDR is in a MIPS16 function.  */
> --- 570,579 ----
>   int
>   mips_use_struct_convention (int gcc_p, struct type *type)
>   {
> !   if (MIPS_EABI || MIPS_NEWABI)
>       return (TYPE_LENGTH (type) > 2 * MIPS_SAVED_REGSIZE);
>     else
> !     return 1;	/* Old ABI: structures are returned by ref in extra arg0 */
>   }
>   

Rather than doing this, can you please create two functions --- one for 
each case --- and then update mips_gdbarch_init() accordingly.

Andrew