Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: ac131313@redhat.com, gdb-patches@sources.redhat.com
Subject: Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit
Date: Wed, 31 Jul 2002 16:47:00 -0000	[thread overview]
Message-ID: <3D4870EB.BB9C282A@redhat.com> (raw)
In-Reply-To: <1020731232203.ZM24308@localhost.localdomain>

Kevin Buettner wrote:
> 
> On Jul 31,  3:44pm, Michael Snyder wrote:
> 
> > >         * mips-tdep.c (mips_push_arguments): Don't assume that
> > >         ``MIPS_SAVED_REGSIZE < 8'' means that the o64 abi is in use.
> > >         Instead, test for it explicitly.
> >
> > Kevin,
> >
> > This change makes things worse for N32.  I haven't tested
> > N64 yet.  I think we're gonna have to look at these lines
> > from the perspective of all 3 (6) abis.
> 
> Okay, this patch is withdrawn while I retest...
> 
> To save some time, can you tell me which N32 regressions you see?

Buncha failures in structs.exp.
If you have a look at the tweak that I sent, it might be the thing.


  reply	other threads:[~2002-07-31 23:39 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-31 15:40 Kevin Buettner
2002-07-31 16:11 ` Michael Snyder
2002-07-31 16:27   ` Kevin Buettner
2002-07-31 16:47     ` Michael Snyder [this message]
2002-07-31 18:16       ` Kevin Buettner
2002-07-31 18:33         ` Kevin Buettner
     [not found]           ` <20020801013959.GA15821@nevyn.them.org>
2002-08-01 16:56             ` Eric Christopher
2002-08-01 17:02               ` Kevin Buettner
2002-08-01 17:08                 ` Eric Christopher
2002-08-01 14:55         ` Andrew Cagney
2002-08-01 15:18           ` Kevin Buettner
2002-08-01 15:27             ` Andrew Cagney
2002-08-01 15:47               ` Kevin Buettner
2002-07-31 16:13 ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D4870EB.BB9C282A@redhat.com \
    --to=msnyder@redhat.com \
    --cc=ac131313@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox