From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13545 invoked by alias); 31 Jul 2002 23:39:40 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13536 invoked from network); 31 Jul 2002 23:39:39 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 31 Jul 2002 23:39:39 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id QAA17910; Wed, 31 Jul 2002 16:39:12 -0700 (PDT) Message-ID: <3D4870EB.BB9C282A@redhat.com> Date: Wed, 31 Jul 2002 16:47:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Kevin Buettner CC: ac131313@redhat.com, gdb-patches@sources.redhat.com Subject: Re: [RFA] mips_push_arguments(): Make O64 ABI test explicit References: <1020731210452.ZM23445@localhost.localdomain> <3D486843.8007D610@redhat.com> <1020731232203.ZM24308@localhost.localdomain> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00646.txt.bz2 Kevin Buettner wrote: > > On Jul 31, 3:44pm, Michael Snyder wrote: > > > > * mips-tdep.c (mips_push_arguments): Don't assume that > > > ``MIPS_SAVED_REGSIZE < 8'' means that the o64 abi is in use. > > > Instead, test for it explicitly. > > > > Kevin, > > > > This change makes things worse for N32. I haven't tested > > N64 yet. I think we're gonna have to look at these lines > > from the perspective of all 3 (6) abis. > > Okay, this patch is withdrawn while I retest... > > To save some time, can you tell me which N32 regressions you see? Buncha failures in structs.exp. If you have a look at the tweak that I sent, it might be the thing.