Re: RFA: gettextize jv-exp.y

[Andrew Cagney <ac131313@ges.redhat.com>]

> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:
> 
> 
> Tom> This patch gettextizes jv-exp.y.
> Tom> In this case one code change was required.  Look at yyerror().
> Tom> Also I fixed a couple of typos while I was at it.
> 
> Andrew> I would have ignored it but you mentioned fixing typos.  Some
> Andrew> more ..
> 
> Ok, how about this patch?  I believe it addresses all the comments in
> your reply.  It compiles with -Werror (I do all my gdb builds that way
> now).

Yep, fine.

> Incidentally it would be convenient if gdb built with `-W'.  This will
> warn about something I let slip in an earlier patch: a function with a
> non-void return type that fails to return a value.  Why is -W not
> used?  (I haven't tried building gdb with it.)
> 
> Andrew> I'm not 100% certain but I believe the intent, in GDB is for
> Andrew> error messages to not include the period?
> 
> I don't know.  Based on my scans through the source, there seems to be
> very little consistency.  I removed all the periods from this file.

There is unfortunatly zero consistency.  I think it can be fixed with a 
later pass though (no need for the person doing internationalization to 
fix minor gramatical errors).

thanks!
Andrew