From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 29850 invoked by alias); 25 Jul 2002 01:45:26 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 29801 invoked from network); 25 Jul 2002 01:45:22 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 25 Jul 2002 01:45:22 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2A0F63D36; Wed, 24 Jul 2002 21:45:22 -0400 (EDT) Message-ID: <3D3F5832.2050007@ges.redhat.com> Date: Wed, 24 Jul 2002 18:49:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020708 X-Accept-Language: en-us, en MIME-Version: 1.0 To: tromey@redhat.com Cc: Andrew Cagney , gdb-patches@sources.redhat.com Subject: Re: RFA: gettextize jv-exp.y References: <87bs9zhp7c.fsf@fleche.redhat.com> <3D192D8C.7000308@cygnus.com> <87n0shw446.fsf@fleche.redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00498.txt.bz2 > "Andrew" == Andrew Cagney writes: > > > Tom> This patch gettextizes jv-exp.y. > Tom> In this case one code change was required. Look at yyerror(). > Tom> Also I fixed a couple of typos while I was at it. > > Andrew> I would have ignored it but you mentioned fixing typos. Some > Andrew> more .. > > Ok, how about this patch? I believe it addresses all the comments in > your reply. It compiles with -Werror (I do all my gdb builds that way > now). Yep, fine. > Incidentally it would be convenient if gdb built with `-W'. This will > warn about something I let slip in an earlier patch: a function with a > non-void return type that fails to return a value. Why is -W not > used? (I haven't tried building gdb with it.) > > Andrew> I'm not 100% certain but I believe the intent, in GDB is for > Andrew> error messages to not include the period? > > I don't know. Based on my scans through the source, there seems to be > very little consistency. I removed all the periods from this file. There is unfortunatly zero consistency. I think it can be fixed with a later pass though (no need for the person doing internationalization to fix minor gramatical errors). thanks! Andrew