Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Petr Sorfa <petrs@caldera.com>
To: Jim Blandy <jimb@redhat.com>
Cc: "gdb-patches@sources.redhat.com" <gdb-patches@sources.redhat.com>
Subject: Re: [PATCH] DWARF support for .debug_loc offsets
Date: Thu, 11 Jul 2002 12:20:00 -0000	[thread overview]
Message-ID: <3D2DD90F.95EEC777@caldera.com> (raw)
In-Reply-To: <npptxuw3jr.fsf@zwingli.cygnus.com>

Hi Jim,

Sorry for the [PATCH] debacle will use [RFA]. Comments below.

> Petr Sorfa <petrs@caldera.com> writes:
> > This patch provides support for offsets into .debug_loc.
> >
> > The patch does not include .debug_loc support in read_tag_string_type()
> > as the DW_AT_string_length attribute is currently being misused by GCC
> > (it uses it to hold the length, rather than the location to the length)
> > and GDB supports the incorrect form.
> >
> > There is a second part of this patch which is dependent on FORTRAN95
> > support of modules and will be released later.
> 
> I'm confused.  If (say) a DW_AT_frame_base attribute's value uses
> DW_FORM_data4 or DW_FORM_data8, then that data is the offset in the
> ..debug_loc section of a location list describing how to find the
> object at various points in the code.  But your code seems to assume
> that the data in the .debug_loc section is simply the address of the
> object.
> 
> Having location list support would be great, but if we can get
> Daniel's LOC_COMPUTED patch committed, adding location list support
> will be very simple.
Oops, you are completely correct. Let me remove the DW_FORM_data4/8
stuff for DW_AT_frame_base and resubmit the patch for RFA. Is this OK?

Petr


  reply	other threads:[~2002-07-11 19:02 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-11 10:37 Petr Sorfa
2002-07-11 10:49 ` Jim Blandy
2002-07-11 10:57   ` Daniel Berlin
2002-07-11 11:10     ` Jim Blandy
2002-07-11 13:58       ` Andrew Cagney
2002-07-11 11:03 ` Jim Blandy
2002-07-11 12:20   ` Petr Sorfa [this message]
2002-07-11 12:22     ` Jim Blandy
2002-07-11 12:44       ` Petr Sorfa

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D2DD90F.95EEC777@caldera.com \
    --to=petrs@caldera.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=jimb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox