From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18619 invoked by alias); 11 Jul 2002 19:02:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18612 invoked from network); 11 Jul 2002 19:02:07 -0000 Received: from unknown (HELO tetsuo.nj.caldera.com) (63.124.204.226) by sources.redhat.com with SMTP; 11 Jul 2002 19:02:07 -0000 Received: from caldera.com (localhost.localdomain [127.0.0.1]) by tetsuo.nj.caldera.com (8.11.6/8.11.6) with ESMTP id g6BJEP404927; Thu, 11 Jul 2002 15:14:25 -0400 Message-ID: <3D2DD90F.95EEC777@caldera.com> Date: Thu, 11 Jul 2002 12:20:00 -0000 From: Petr Sorfa Organization: Caldera X-Accept-Language: en MIME-Version: 1.0 To: Jim Blandy CC: "gdb-patches@sources.redhat.com" Subject: Re: [PATCH] DWARF support for .debug_loc offsets References: <3D2DB435.AC2C6DA0@caldera.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00240.txt.bz2 Hi Jim, Sorry for the [PATCH] debacle will use [RFA]. Comments below. > Petr Sorfa writes: > > This patch provides support for offsets into .debug_loc. > > > > The patch does not include .debug_loc support in read_tag_string_type() > > as the DW_AT_string_length attribute is currently being misused by GCC > > (it uses it to hold the length, rather than the location to the length) > > and GDB supports the incorrect form. > > > > There is a second part of this patch which is dependent on FORTRAN95 > > support of modules and will be released later. > > I'm confused. If (say) a DW_AT_frame_base attribute's value uses > DW_FORM_data4 or DW_FORM_data8, then that data is the offset in the > ..debug_loc section of a location list describing how to find the > object at various points in the code. But your code seems to assume > that the data in the .debug_loc section is simply the address of the > object. > > Having location list support would be great, but if we can get > Daniel's LOC_COMPUTED patch committed, adding location list support > will be very simple. Oops, you are completely correct. Let me remove the DW_FORM_data4/8 stuff for DW_AT_frame_base and resubmit the patch for RFA. Is this OK? Petr