Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@ges.redhat.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: GDB Patches <gdb-patches@sources.redhat.com>
Subject: Re: [RFA] struct context moved
Date: Mon, 08 Jul 2002 11:36:00 -0000	[thread overview]
Message-ID: <3D29DA42.1060508@ges.redhat.com> (raw)
In-Reply-To: <3D29A1D5.2010700@suse.cz>

> Hi all,
> the appended patch moved declaration of struct context and struct context_reg to frame.h, where these two are used in struct frame_info.
> OK to commit?
> 
> 2002-07-08  Michal Ludvig  <mludvig@suse.cz>
> 
>     * dwarf2cfi.c (struct context, struct context_reg): Moved...
>     * farme.h (struct context, struct context_reg): ...here.
> 
> Michal Ludvig 

Michael,

I don't understand the rationale behind this.

As a general trend, frame.h / struct frame is becomming increasingly 
opaque.  I don't see a reason for moving dwarf2cfi specific stuff into 
frame.h.

Can I also suggest looking at the unwind functions - they take an 
unwind_cache parameter that can be used to save unwind specific information.

Andrew



  reply	other threads:[~2002-07-08 18:30 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-07-08  8:28 Michal Ludvig
2002-07-08 11:36 ` Andrew Cagney [this message]
2002-07-08 13:46   ` Michal Ludvig
2002-07-09  8:07     ` Andrew Cagney
2002-08-26 19:24     ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3D29DA42.1060508@ges.redhat.com \
    --to=ac131313@ges.redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mludvig@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox