From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 6178 invoked by alias); 8 Jul 2002 18:30:37 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 6107 invoked from network); 8 Jul 2002 18:30:34 -0000 Received: from unknown (HELO localhost.redhat.com) (66.30.197.194) by sources.redhat.com with SMTP; 8 Jul 2002 18:30:34 -0000 Received: from ges.redhat.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6508F3C65; Mon, 8 Jul 2002 14:30:28 -0400 (EDT) Message-ID: <3D29DA42.1060508@ges.redhat.com> Date: Mon, 08 Jul 2002 11:36:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0.0) Gecko/20020613 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michal Ludvig Cc: GDB Patches Subject: Re: [RFA] struct context moved References: <3D29A1D5.2010700@suse.cz> Content-Type: text/plain; charset=ISO-8859-2; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-07/txt/msg00117.txt.bz2 > Hi all, > the appended patch moved declaration of struct context and struct context_reg to frame.h, where these two are used in struct frame_info. > OK to commit? > > 2002-07-08 Michal Ludvig > > * dwarf2cfi.c (struct context, struct context_reg): Moved... > * farme.h (struct context, struct context_reg): ...here. > > Michal Ludvig Michael, I don't understand the rationale behind this. As a general trend, frame.h / struct frame is becomming increasingly opaque. I don't see a reason for moving dwarf2cfi specific stuff into frame.h. Can I also suggest looking at the unwind functions - they take an unwind_cache parameter that can be used to save unwind specific information. Andrew