Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* RFA: don't repeat `delete' command
@ 2002-06-24 13:46 Tom Tromey
  2002-06-25 19:37 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: Tom Tromey @ 2002-06-24 13:46 UTC (permalink / raw)
  To: gdb-patches

Right now the `delete' command will repeat if you hit enter again
after it completes.  Then it proceeds to give an error message, since
you've already deleted the breakpoints in question.

I've run across this by accident a few times recently.  It seems a bit
odd to me, and I'd prefer that the `delete' command not repeat.  Hence
this patch.

Ok?

Tom

Index: ChangeLog
from  Tom Tromey  <tromey@redhat.com>

	* breakpoint.c (delete_command): Don't repeat `delete' commands.

Index: breakpoint.c
===================================================================
RCS file: /cvs/src/src/gdb/breakpoint.c,v
retrieving revision 1.77
diff -u -r1.77 breakpoint.c
--- breakpoint.c 18 Jun 2002 21:58:55 -0000 1.77
+++ breakpoint.c 24 Jun 2002 20:43:14 -0000
@@ -6769,6 +6769,8 @@
 {
   struct breakpoint *b, *temp;
 
+  dont_repeat ();
+
   if (arg == 0)
     {
       int breaks_to_delete = 0;


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RFA: don't repeat `delete' command
  2002-06-24 13:46 RFA: don't repeat `delete' command Tom Tromey
@ 2002-06-25 19:37 ` Andrew Cagney
  2002-06-25 22:23   ` Tom Tromey
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2002-06-25 19:37 UTC (permalink / raw)
  To: tromey; +Cc: gdb-patches, Fernando Nasser

> I've run across this by accident a few times recently.  It seems a bit
> odd to me, and I'd prefer that the `delete' command not repeat.  Hence
> this patch.
> 
> Ok?

Yes.  Deleting something already deleted is somewhat useless.

Andrew

> Index: ChangeLog
> from  Tom Tromey  <tromey@redhat.com>
> 
> 	* breakpoint.c (delete_command): Don't repeat `delete' commands.
> 



^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: RFA: don't repeat `delete' command
  2002-06-25 19:37 ` Andrew Cagney
@ 2002-06-25 22:23   ` Tom Tromey
  0 siblings, 0 replies; 3+ messages in thread
From: Tom Tromey @ 2002-06-25 22:23 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches, Fernando Nasser

>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:

>> I've run across this by accident a few times recently.  It seems a
>> bit odd to me, and I'd prefer that the `delete' command not repeat.
>> Hence this patch.  Ok?

Andrew> Yes.  Deleting something already deleted is somewhat useless.

I checked this in.  Thanks.

Tom


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-06-26  5:23 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-06-24 13:46 RFA: don't repeat `delete' command Tom Tromey
2002-06-25 19:37 ` Andrew Cagney
2002-06-25 22:23   ` Tom Tromey

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox