sim/m68hc11 daa a->a

sim/m68hc11 daa a->a

[Andrew Cagney]

Stephane,

When trying out a build with --enable-sim-build-warnings=,-Werror(1) I 
noticed:

     case 0x19: /* daa a->a */
       src8 = cpu_get_a (proc);
       cpu_special (proc, M6811_DAA);
       cpu_set_a (proc, dst8);
       break;

(the generated file m68hc11int.c)  GCC is complaining that dst8 might be 
used uninitialized.

enjoy,
Andrew


(1) No one has tried this for a long time

Re: sim/m68hc11 daa a->a

[Stephane Carrez]

Hi Andrew,

Andrew Cagney wrote:

> Stephane,
> 
> When trying out a build with --enable-sim-build-warnings=,-Werror(1) I 
> noticed:
> 
>     case 0x19: /* daa a->a */
>       src8 = cpu_get_a (proc);
>       cpu_special (proc, M6811_DAA);
>       cpu_set_a (proc, dst8);
>       break;
> 
> (the generated file m68hc11int.c)  GCC is complaining that dst8 might be 
> used uninitialized.

Ok.  It needs a cleanup.

Heu... it also needs an implementation...in cpu_special().

> 
> enjoy,
> Andrew
> 
> 
> (1) No one has tried this for a long time
> 

To be honest I don't use -Werror...

Thanks!,
	Stephane

-----------------------------------------------------------------------
         Home                               Office
E-mail: stcarrez@nerim.fr                  Stephane.Carrez@solsoft.fr
WWW:    http://stephane.carrez.free.fr     http://www.solsoft.com
	Free the Software!		   Visual Security Policy Management

Re: sim/m68hc11 daa a->a

[Andrew Cagney]

> 
> 
> enjoy,
> Andrew
> 
> 
> (1) No one has tried this for a long time
> 
> 
> To be honest I don't use -Werror... 

:-)  Well, with these tweaks fixed, it can be again.

For those into statistics:  There were ~10 -Werror messages of which 3 
identified real bugs!  Not bad - pretty cheap way of finding bugs before 
the code is shipped :-)

Andrew