Re: [PATCH] remove ada-exp.tab.c

[Andrew Cagney <ac131313@cygnus.com>]

> On Wed, Jun 05, 2002 at 12:33:19PM -0400, Andrew Cagney wrote
> 
> 
>> For .l and .y files I think they really should be rebuildable with any 
>> (and not a specific lex/yacc et.al.).
> 
> 
> I have access to FreeBSD and OpenBSD machines, and an Irix box if I
> don't scrub it for debian, is there a reasonably brain-dead
> implementation available for these that I can test with?

Try it with the boxes you have access to.  However, no need to go out of 
your way.  If developers encounter problems on various hosts they will 
soon let us know :-)

> If nobody has any further objects, I'll remove ada-exp.tab.c tommorrow
> morning.

No need to wait. I believe that ada-lex.c is also generated and, hence, 
should be deleted for similar reasons.

Anyway, now that the code is in CVS I've had a better look.  The 
immediate things are very standard:

- coding style, I noticed things like:
	for () {
	}
The fix is to put the .[hc] files through gdb_indent.sh and commit the 
result.

- See http://sources.redhat.com/gdb/current/ari/ and note the 
regressions (things purged from GDB) related to the ada files.  Things 
like malloc, free, printf("%p") et.al.  You could also look at errors 
and deprecated, however regressions are the big ones(1).

- Can it be built when configured with configured with 
--enable-gdb-build-warnings=,-Werror and fix the results.  If you hit 
problems due to those #if 0's don't be to worried at this stage.

- I noticed that the debug code is using ``fprintf (stderr, ...''.  It 
should use ``fprintf_unfiltered (gdb_stdlog, ...''.  It isn't under 
regressions since the purge of fprintf() is ongoing.  I don't think it 
is fair to give Pierre more work to do though :-)

These are all considered `obvious' so, at your lesure.


Do you want to start working through the other changes?


enjoy,
Andrew

(1) I checked the table last night and the script/table contained a bug. 
  Todays re-generate will be more correct.