From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 26257 invoked by alias); 6 Jun 2002 16:21:06 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 26249 invoked from network); 6 Jun 2002 16:21:04 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 6 Jun 2002 16:21:04 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 8E2EF3E32; Thu, 6 Jun 2002 12:21:17 -0400 (EDT) Message-ID: <3CFF8BFD.6070405@cygnus.com> Date: Thu, 06 Jun 2002 09:21:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc3) Gecko/20020530 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Aidan Skinner Cc: gdb-patches@sources.redhat.com Subject: Re: [PATCH] remove ada-exp.tab.c References: <20020604210319.A617@velvet.net> <20020605090551.A8208@gnat.com> <3CFE3D4F.4030607@cygnus.com> <20020606164924.S617@velvet.net> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-06/txt/msg00090.txt.bz2 > On Wed, Jun 05, 2002 at 12:33:19PM -0400, Andrew Cagney wrote > > >> For .l and .y files I think they really should be rebuildable with any >> (and not a specific lex/yacc et.al.). > > > I have access to FreeBSD and OpenBSD machines, and an Irix box if I > don't scrub it for debian, is there a reasonably brain-dead > implementation available for these that I can test with? Try it with the boxes you have access to. However, no need to go out of your way. If developers encounter problems on various hosts they will soon let us know :-) > If nobody has any further objects, I'll remove ada-exp.tab.c tommorrow > morning. No need to wait. I believe that ada-lex.c is also generated and, hence, should be deleted for similar reasons. Anyway, now that the code is in CVS I've had a better look. The immediate things are very standard: - coding style, I noticed things like: for () { } The fix is to put the .[hc] files through gdb_indent.sh and commit the result. - See http://sources.redhat.com/gdb/current/ari/ and note the regressions (things purged from GDB) related to the ada files. Things like malloc, free, printf("%p") et.al. You could also look at errors and deprecated, however regressions are the big ones(1). - Can it be built when configured with configured with --enable-gdb-build-warnings=,-Werror and fix the results. If you hit problems due to those #if 0's don't be to worried at this stage. - I noticed that the debug code is using ``fprintf (stderr, ...''. It should use ``fprintf_unfiltered (gdb_stdlog, ...''. It isn't under regressions since the purge of fprintf() is ongoing. I don't think it is fair to give Pierre more work to do though :-) These are all considered `obvious' so, at your lesure. Do you want to start working through the other changes? enjoy, Andrew (1) I checked the table last night and the script/table contained a bug. Todays re-generate will be more correct.