Re: [RFC] GDB interpreters

[Andrew Cagney <ac131313@cygnus.com>]

> I will be adding documentation for the MI part of the GDB manual and I
> will be writing testsuites to cover all this. That aside, it is a
> non-trivial change to all sorts of things in gdb to get this working. I
> thought I would start with this and work my way out to other, more
> invasive changes.

Do you have a [working] draft?  It is hard to see how it hangs together 
with out some additional context.  Consider doing what I did and drop 
the work in progress onto a branch.

The things I'm wondering about are:

- how the ``struct gdb_interpreter'' gets called (can it be opaque?). 
There is a comment talking about how it is tied into the event loop.

- what goes with hooks (I get the feeling that it is caught in the 
middle between ..._hook and gdb-event*)

I think, though, it is basicly fine.

Andrew

BTW: Some quick coding cleanups you've had handed down.  I'll try to get 
the comment one added to the ARI.

Perhaphs consider a name other than interpreter.[hc].  Something to 
reflect that this isn't ``the'' interpreter but rather a part of the 
interpreters.  terps? :-^  interps?


> static struct gdb_interpreter *interp_list = NULL;
> static struct gdb_interpreter *current = NULL;

Suggest ``current_interpreter''.

> static int initialized = 0;

Same.

> /* gdb_new_interpreter - This allocates space for a new interpreter,
>  * fills the fields from the inputs, and returns a pointer to the
>  * interpreter. */

I think it is ment to be:

/* .....
    ..... */

i.e. no `*' on each line.

--