From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 7036 invoked by alias); 24 May 2002 22:00:52 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 7012 invoked from network); 24 May 2002 22:00:49 -0000 Received: from unknown (HELO localhost.redhat.com) (66.31.105.161) by sources.redhat.com with SMTP; 24 May 2002 22:00:49 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id B80B73CBF; Fri, 24 May 2002 18:00:58 -0400 (EDT) Message-ID: <3CEEB81A.2010407@cygnus.com> Date: Fri, 24 May 2002 15:38:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc2) Gecko/20020518 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Keith Seitz Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] GDB interpreters References: Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00906.txt.bz2 > I will be adding documentation for the MI part of the GDB manual and I > will be writing testsuites to cover all this. That aside, it is a > non-trivial change to all sorts of things in gdb to get this working. I > thought I would start with this and work my way out to other, more > invasive changes. Do you have a [working] draft? It is hard to see how it hangs together with out some additional context. Consider doing what I did and drop the work in progress onto a branch. The things I'm wondering about are: - how the ``struct gdb_interpreter'' gets called (can it be opaque?). There is a comment talking about how it is tied into the event loop. - what goes with hooks (I get the feeling that it is caught in the middle between ..._hook and gdb-event*) I think, though, it is basicly fine. Andrew BTW: Some quick coding cleanups you've had handed down. I'll try to get the comment one added to the ARI. Perhaphs consider a name other than interpreter.[hc]. Something to reflect that this isn't ``the'' interpreter but rather a part of the interpreters. terps? :-^ interps? > static struct gdb_interpreter *interp_list = NULL; > static struct gdb_interpreter *current = NULL; Suggest ``current_interpreter''. > static int initialized = 0; Same. > /* gdb_new_interpreter - This allocates space for a new interpreter, > * fills the fields from the inputs, and returns a pointer to the > * interpreter. */ I think it is ment to be: /* ..... ..... */ i.e. no `*' on each line. --