Re: [OB] Fix xcoffread.c build error

[Tristan Gingold <gingold@adacore.com>]

On May 24, 2011, at 6:27 PM, Pedro Alves wrote:

[...]

> It that were possible, then why would we need fcn_aux_saved
> at all?  This is a bit hard to follow without a
> file to test with, but ISTM that fcn_aux_saved is needed because
> main_aux no longer contains what we need at the time time
> fcn_aux_saved is used (that is, we've moved to
> another symbol/aux).
> 
> Does gcc still output a warning with this for you?
> 
> Maybe Tristian can check if this doesn't break something?

I can do a sanity check if you need (please confirm), but a full regression (using AdaCore testsuite)
will be done when Joel updates our head branch.

> (I suppose fcn_aux_saved and a bunch other locals should be
> cleared somewhere, most likely after finish_block, or
> where we do the complaints.)

Your change looks safe, but as fcn_aux_saved_p is never cleared, it will catch
only if the missing PR symbol is the first one.

IMHO (and just IMHO), to get rid of the warning why not saving only the fsize field (instead of
the whole aux entry) and initialize to 0 ?

Tristan.