From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 28858 invoked by alias); 25 May 2011 07:21:10 -0000 Received: (qmail 28838 invoked by uid 22791); 25 May 2011 07:21:08 -0000 X-SWARE-Spam-Status: No, hits=-1.8 required=5.0 tests=AWL,BAYES_00,TW_FC X-Spam-Check-By: sourceware.org Received: from mel.act-europe.fr (HELO mel.act-europe.fr) (194.98.77.210) by sourceware.org (qpsmtpd/0.43rc1) with ESMTP; Wed, 25 May 2011 07:20:52 +0000 Received: from localhost (localhost [127.0.0.1]) by filtered-smtp.eu.adacore.com (Postfix) with ESMTP id 18475CB035E; Wed, 25 May 2011 09:20:51 +0200 (CEST) Received: from mel.act-europe.fr ([127.0.0.1]) by localhost (smtp.eu.adacore.com [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id CBfx5tTOSAMb; Wed, 25 May 2011 09:20:48 +0200 (CEST) Received: from ulanbator.act-europe.fr (ulanbator.act-europe.fr [10.10.1.67]) (using TLSv1 with cipher AES128-SHA (128/128 bits)) (No client certificate requested) by mel.act-europe.fr (Postfix) with ESMTP id 140AACB01FC; Wed, 25 May 2011 09:20:47 +0200 (CEST) Subject: Re: [OB] Fix xcoffread.c build error Mime-Version: 1.0 (Apple Message framework v1084) Content-Type: text/plain; charset=us-ascii From: Tristan Gingold In-Reply-To: <201105241727.43826.pedro@codesourcery.com> Date: Wed, 25 May 2011 07:21:00 -0000 Cc: Hui Zhu , gdb-patches@sourceware.org Content-Transfer-Encoding: quoted-printable Message-Id: <3CE959C7-9DD8-46A7-9FAC-230C3E2DCA55@adacore.com> References: <201105191059.02173.pedro@codesourcery.com> <201105241727.43826.pedro@codesourcery.com> To: Pedro Alves X-IsSubscribed: yes Mailing-List: contact gdb-patches-help@sourceware.org; run by ezmlm Precedence: bulk List-Id: List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sourceware.org X-SW-Source: 2011-05/txt/msg00580.txt.bz2 On May 24, 2011, at 6:27 PM, Pedro Alves wrote: [...] > It that were possible, then why would we need fcn_aux_saved > at all? This is a bit hard to follow without a > file to test with, but ISTM that fcn_aux_saved is needed because > main_aux no longer contains what we need at the time time > fcn_aux_saved is used (that is, we've moved to > another symbol/aux). >=20 > Does gcc still output a warning with this for you? >=20 > Maybe Tristian can check if this doesn't break something? I can do a sanity check if you need (please confirm), but a full regression= (using AdaCore testsuite) will be done when Joel updates our head branch. > (I suppose fcn_aux_saved and a bunch other locals should be > cleared somewhere, most likely after finish_block, or > where we do the complaints.) Your change looks safe, but as fcn_aux_saved_p is never cleared, it will ca= tch only if the missing PR symbol is the first one. IMHO (and just IMHO), to get rid of the warning why not saving only the fsi= ze field (instead of the whole aux entry) and initialize to 0 ? Tristan.