From: Andrew Cagney <ac131313@cygnus.com>
To: Kazu Hirata <kazu@cs.umass.edu>,
Andrew Volkov <Andrew.Volkov@transas.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] sim/h8300/compile.c: Fix formatting.
Date: Sat, 18 May 2002 12:43:00 -0000 [thread overview]
Message-ID: <3CE6AEDD.6010605@cygnus.com> (raw)
In-Reply-To: <20020518.074029.25910897.kazu@cs.umass.edu>
> Hi,
>
> Attached is a patch to fix formatting. Committed as obvious.
>
> Kazu Hirata
Kazu, thanks!
I gather you did this by hand though:
+
if((_dst+count)>=(cpu.memory+memory_size))
For GDB, there is an easier way. Just run:
$ cd src/sim/h8300
$ ../../gdb/gdb_indent.sh compile.sh
Not in GDB directory
Er, oops! Hang on I'll just fix that.
AndrewV,
Don't forget the coding standard:
http://www.gnu.org/prep/standards_toc.html
One thing I noticed is variables like ``_dst''. The leading underscore
shouldn't be used.
enjoy,
Andrew
next prev parent reply other threads:[~2002-05-18 19:43 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-05-18 4:41 Kazu Hirata
2002-05-18 12:43 ` Andrew Cagney [this message]
2002-05-19 4:59 ` Kazu Hirata
2002-05-20 3:22 Andrew Volkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CE6AEDD.6010605@cygnus.com \
--to=ac131313@cygnus.com \
--cc=Andrew.Volkov@transas.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kazu@cs.umass.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox