From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-15743-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 15932 invoked by alias); 18 May 2002 19:43:22 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 15924 invoked from network); 18 May 2002 19:43:21 -0000
Received: from unknown (HELO localhost.redhat.com) (24.112.240.27)
  by sources.redhat.com with SMTP; 18 May 2002 19:43:21 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id E70A03E98; Sat, 18 May 2002 15:43:25 -0400 (EDT)
Message-ID: <3CE6AEDD.6010605@cygnus.com>
Date: Sat, 18 May 2002 12:43:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc2) Gecko/20020518
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kazu Hirata <kazu@cs.umass.edu>,
	Andrew Volkov <Andrew.Volkov@transas.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch] sim/h8300/compile.c: Fix formatting.
References: <20020518.074029.25910897.kazu@cs.umass.edu>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-05/txt/msg00791.txt.bz2

> Hi,
> 
> Attached is a patch to fix formatting.  Committed as obvious.
> 
> Kazu Hirata

Kazu, thanks!

I gather you did this by hand though:

+ 
       if((_dst+count)>=(cpu.memory+memory_size))

For GDB, there is an easier way.  Just run:

	$ cd src/sim/h8300
	$ ../../gdb/gdb_indent.sh compile.sh
	Not in GDB directory

Er, oops!  Hang on I'll just fix that.

AndrewV,

Don't forget the coding standard:

	http://www.gnu.org/prep/standards_toc.html

One thing I noticed is variables like ``_dst''.  The leading underscore 
shouldn't be used.

enjoy,
Andrew