Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [PATCH] Fix thinko in mips-tdep.c
@ 2002-05-10 18:57 Eric Christopher
  2002-05-10 19:16 ` Andrew Cagney
  2002-05-10 21:00 ` Daniel Jacobowitz
  0 siblings, 2 replies; 3+ messages in thread
From: Eric Christopher @ 2002-05-10 18:57 UTC (permalink / raw)
  To: gdb-patches

Daniel had a small thinko when writing the support for
mips_double(single)_register_type. This should fix it.

OK?

-eric

ps. I dont' think I have write after approval for gdb so someone should
check this in :)

-- 
I will not carve gods

2002-05-10  Eric Christopher  <echristo@redhat.com>

	* mips-tdep.c (mips_double_register_type): Fix thinko.
	(mips_single_register_type): Ditto.

Index: mips-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/mips-tdep.c,v
retrieving revision 1.72
diff -u -p -w -r1.72 mips-tdep.c
--- mips-tdep.c	9 May 2002 22:26:00 -0000	1.72
+++ mips-tdep.c	11 May 2002 01:52:28 -0000
@@ -2744,7 +2744,7 @@ mips_pop_frame (void)
 static struct type *
 mips_float_register_type (void)
 {
-  if (TARGET_BYTE_ORDER == BFD_BIG_ENDIAN)
+  if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
     return builtin_type_ieee_single_big;
   else
     return builtin_type_ieee_single_little;
@@ -2753,7 +2753,7 @@ mips_float_register_type (void)
 static struct type *
 mips_double_register_type (void)
 {
-  if (TARGET_BYTE_ORDER == BFD_BIG_ENDIAN)
+  if (TARGET_BYTE_ORDER == BFD_ENDIAN_BIG)
     return builtin_type_ieee_double_big;
   else
     return builtin_type_ieee_double_little;
@@ -4979,4 +4979,3 @@ that would transfer 32 bits for some reg
 When non-zero, mips specific debugging is enabled.", &setdebuglist),
 		     &showdebuglist);
 }
-


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix thinko in mips-tdep.c
  2002-05-10 18:57 [PATCH] Fix thinko in mips-tdep.c Eric Christopher
@ 2002-05-10 19:16 ` Andrew Cagney
  2002-05-10 21:00 ` Daniel Jacobowitz
  1 sibling, 0 replies; 3+ messages in thread
From: Andrew Cagney @ 2002-05-10 19:16 UTC (permalink / raw)
  To: Eric Christopher; +Cc: gdb-patches

> 2002-05-10  Eric Christopher  <echristo@redhat.com>
> 
> 	* mips-tdep.c (mips_double_register_type): Fix thinko.
> 	(mips_single_register_type): Ditto.
> 
Yep.

Also feel free to add your self to the maintainers file as an obvious fix.

Andrew




^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [PATCH] Fix thinko in mips-tdep.c
  2002-05-10 18:57 [PATCH] Fix thinko in mips-tdep.c Eric Christopher
  2002-05-10 19:16 ` Andrew Cagney
@ 2002-05-10 21:00 ` Daniel Jacobowitz
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2002-05-10 21:00 UTC (permalink / raw)
  To: Eric Christopher; +Cc: gdb-patches

On Fri, May 10, 2002 at 06:55:10PM -0700, Eric Christopher wrote:
> Daniel had a small thinko when writing the support for
> mips_double(single)_register_type. This should fix it.
> 
> OK?
> 
> -eric
> 
> ps. I dont' think I have write after approval for gdb so someone should
> check this in :)
> 
> -- 
> I will not carve gods
> 
> 2002-05-10  Eric Christopher  <echristo@redhat.com>
> 
> 	* mips-tdep.c (mips_double_register_type): Fix thinko.
> 	(mips_single_register_type): Ditto.

Err... I could swear I'd fixed that; I guess I got the wrong copy of
the patch.  Thanks!

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-05-11  4:00 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-05-10 18:57 [PATCH] Fix thinko in mips-tdep.c Eric Christopher
2002-05-10 19:16 ` Andrew Cagney
2002-05-10 21:00 ` Daniel Jacobowitz

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox