Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Daniel Jacobowitz <drow@mvista.com>
Cc: Tom Tromey <tromey@redhat.com>, gdb-patches@sources.redhat.com
Subject: Re: Patch: printing java `char' values
Date: Wed, 08 May 2002 15:39:00 -0000	[thread overview]
Message-ID: <3CD9A5EE.DE42EEA1@redhat.com> (raw)
In-Reply-To: <20020508212020.GA4389@nevyn.them.org>

Daniel Jacobowitz wrote:
> 
> On Wed, May 08, 2002 at 01:57:21PM -0700, Michael Snyder wrote:
> > I'd prefer not to perpetuate TYPE_CODE_CHAR.  This seems to have been
> > a one-time thing, and not (I think) a good idea.  In general if GDB
> > wants to know if two things can be added or XOR'd or something, it
> > only needs to check to see if they are TYPE_CODE_INT, (because chars
> > are really ints of size 1).  This should have been implemented as a
> > TYPE_FLAG_*, not a TYPE_CODE-*.
> 
> Sounds good to me.  Would you be interested in patches which actually
> change TYPE_CODE_CHAR to TYPE_FLAG_CHAR, if it's practical?

Uhh, sure.  That would be a non-trivial change, and it might take
a little effort to verify that it was transparent... but I think
the idea is good (quite apart from the fact that I thought of it <g>)


  reply	other threads:[~2002-05-08 22:39 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-05-06 10:11 Tom Tromey
2002-05-06 17:05 ` Michael Snyder
2002-05-07 13:29   ` Tom Tromey
2002-05-07 15:45     ` Andrew Cagney
2002-05-07 13:43 ` Daniel Jacobowitz
2002-05-07 14:22 ` Michael Snyder
2002-05-07 14:35   ` Tom Tromey
2002-05-08 12:12     ` Michael Snyder
2002-05-08 12:47       ` Daniel Jacobowitz
2002-05-08 13:32         ` Tom Tromey
2002-05-08 13:46           ` Daniel Jacobowitz
2002-05-08 14:10             ` Michael Snyder
2002-05-08 14:20               ` Daniel Jacobowitz
2002-05-08 15:39                 ` Michael Snyder [this message]
2002-05-08 15:42       ` Tom Tromey
2002-05-08 16:52         ` Michael Snyder
2002-05-08 21:09           ` Tom Tromey
2002-05-09 11:09             ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CD9A5EE.DE42EEA1@redhat.com \
    --to=msnyder@redhat.com \
    --cc=drow@mvista.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=tromey@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox