From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 13484 invoked by alias); 8 May 2002 22:39:08 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 13458 invoked from network); 8 May 2002 22:39:05 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 8 May 2002 22:39:05 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id PAA03422; Wed, 8 May 2002 15:38:56 -0700 (PDT) Message-ID: <3CD9A5EE.DE42EEA1@redhat.com> Date: Wed, 08 May 2002 15:39:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Daniel Jacobowitz CC: Tom Tromey , gdb-patches@sources.redhat.com Subject: Re: Patch: printing java `char' values References: <877kmh8a6r.fsf@creche.redhat.com> <3CD8429E.DA6D6BC7@redhat.com> <873cx3vdhy.fsf@creche.redhat.com> <3CD9756D.F0AE4AF@redhat.com> <20020508194746.GA31548@nevyn.them.org> <878z6umkwn.fsf@creche.redhat.com> <20020508204626.GA2093@nevyn.them.org> <3CD99131.76E0B9BB@redhat.com> <20020508212020.GA4389@nevyn.them.org> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00236.txt.bz2 Daniel Jacobowitz wrote: > > On Wed, May 08, 2002 at 01:57:21PM -0700, Michael Snyder wrote: > > I'd prefer not to perpetuate TYPE_CODE_CHAR. This seems to have been > > a one-time thing, and not (I think) a good idea. In general if GDB > > wants to know if two things can be added or XOR'd or something, it > > only needs to check to see if they are TYPE_CODE_INT, (because chars > > are really ints of size 1). This should have been implemented as a > > TYPE_FLAG_*, not a TYPE_CODE-*. > > Sounds good to me. Would you be interested in patches which actually > change TYPE_CODE_CHAR to TYPE_FLAG_CHAR, if it's practical? Uhh, sure. That would be a non-trivial change, and it might take a little effort to verify that it was transparent... but I think the idea is good (quite apart from the fact that I thought of it )