Re: [PATCH] Testing tweaks for xscale

[Michael Snyder <msnyder@redhat.com>]

Richard Earnshaw wrote:
> 
> > 2002-05-02  Michael Snyder  <msnyder@redhat.com>
> >
> >       * gdb.base/long_long.exp: Add xscale target.
> >       * gdb.base/default.exp: Add xscale target.
> >
> > Index: gdb.base/default.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v
> > retrieving revision 1.9
> > diff -p -r1.9 default.exp
> > *** gdb.base/default.exp      29 Mar 2002 01:19:11 -0000      1.9
> > --- gdb.base/default.exp      3 May 2002 21:23:13 -0000
> > *************** gdb_test "info files" "" "info files"
> > *** 348,353 ****
> > --- 348,355 ----
> >   #test info float
> >   if [istarget "arm*-*-*"] then {
> >       gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float"
> > + } elseif [istarget "xscale*-*-*"] then {
> > +     gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float"
> >   } elseif [istarget "thumb*-*-*"] then {
> >       gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float"
> >   } elseif [istarget "strongarm*-*-*"] then {
> > Index: gdb.base/long_long.exp
> > ===================================================================
> > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/long_long.exp,v
> > retrieving revision 1.7
> > diff -p -r1.7 long_long.exp
> > *** gdb.base/long_long.exp    17 Jul 2001 22:19:49 -0000      1.7
> > --- gdb.base/long_long.exp    3 May 2002 21:23:13 -0000
> > *************** if { $sizeof_double == 8 } {
> > *** 157,162 ****
> > --- 157,167 ----
> >   #   assume the long long represents a floating point double in ARM format
> >        gdb_test "p/f oct" ".*2.1386676354387559e\\+265.*"
> >
> > +   } elseif [ istarget "xscale*-*-*" ] then {
> > +
> > + #   assume the long long represents a floating point double in ARM format
> > +      gdb_test "p/f oct" ".*2.1386676354387559e\\+265.*"
> > +
> >     } else {
> >
> >   #   assume the long long represents a floating point double in little
> 
> I'm assuming here that maintainership of the ARM parts includes changes
> like this to the testsuite...

Definitely I want your input.


> Two points.
> 
> 1) Since xscale is an ARM processor variant, I think these should be kept
> as a single "if" clause -- clearly we intend to do the same thing for both.
> 
> 2) The following thumb clause is, I think, now dead -- thumb support has
> been rolled into the ARM configuration.
> 
> So I think the first change should be something like
> 
>    if {[istarget "arm*-*-*"] || [istarget "xscale*-*-*"]
>        || [istarget "strongarm*-*-*"]} then {
>        gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info
> float"
>    } else {.... non-arm things...

Thanks, I agree.  Checking in the correction.

BTW, long_long.exp does not mention the strongarm.
Should it?  Should strongarm go into the same clause as arm?