From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 3216 invoked by alias); 8 May 2002 21:03:48 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 3201 invoked from network); 8 May 2002 21:03:47 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 8 May 2002 21:03:47 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id OAA24783; Wed, 8 May 2002 14:03:43 -0700 (PDT) Message-ID: <3CD98F9D.A99D57EA@redhat.com> Date: Wed, 08 May 2002 14:03:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com CC: Michael Snyder , gdb-patches@sources.redhat.com, rearnsha@arm.com Subject: Re: [PATCH] Testing tweaks for xscale References: <200205081528.QAA18424@cam-mail2.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00231.txt.bz2 Richard Earnshaw wrote: > > > 2002-05-02 Michael Snyder > > > > * gdb.base/long_long.exp: Add xscale target. > > * gdb.base/default.exp: Add xscale target. > > > > Index: gdb.base/default.exp > > =================================================================== > > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/default.exp,v > > retrieving revision 1.9 > > diff -p -r1.9 default.exp > > *** gdb.base/default.exp 29 Mar 2002 01:19:11 -0000 1.9 > > --- gdb.base/default.exp 3 May 2002 21:23:13 -0000 > > *************** gdb_test "info files" "" "info files" > > *** 348,353 **** > > --- 348,355 ---- > > #test info float > > if [istarget "arm*-*-*"] then { > > gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float" > > + } elseif [istarget "xscale*-*-*"] then { > > + gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float" > > } elseif [istarget "thumb*-*-*"] then { > > gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info float" > > } elseif [istarget "strongarm*-*-*"] then { > > Index: gdb.base/long_long.exp > > =================================================================== > > RCS file: /cvs/src/src/gdb/testsuite/gdb.base/long_long.exp,v > > retrieving revision 1.7 > > diff -p -r1.7 long_long.exp > > *** gdb.base/long_long.exp 17 Jul 2001 22:19:49 -0000 1.7 > > --- gdb.base/long_long.exp 3 May 2002 21:23:13 -0000 > > *************** if { $sizeof_double == 8 } { > > *** 157,162 **** > > --- 157,167 ---- > > # assume the long long represents a floating point double in ARM format > > gdb_test "p/f oct" ".*2.1386676354387559e\\+265.*" > > > > + } elseif [ istarget "xscale*-*-*" ] then { > > + > > + # assume the long long represents a floating point double in ARM format > > + gdb_test "p/f oct" ".*2.1386676354387559e\\+265.*" > > + > > } else { > > > > # assume the long long represents a floating point double in little > > I'm assuming here that maintainership of the ARM parts includes changes > like this to the testsuite... Definitely I want your input. > Two points. > > 1) Since xscale is an ARM processor variant, I think these should be kept > as a single "if" clause -- clearly we intend to do the same thing for both. > > 2) The following thumb clause is, I think, now dead -- thumb support has > been rolled into the ARM configuration. > > So I think the first change should be something like > > if {[istarget "arm*-*-*"] || [istarget "xscale*-*-*"] > || [istarget "strongarm*-*-*"]} then { > gdb_test "info float" "Software FPU type.*mask:.*flags:.*" "info > float" > } else {.... non-arm things... Thanks, I agree. Checking in the correction. BTW, long_long.exp does not mention the strongarm. Should it? Should strongarm go into the same clause as arm?