Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Michal Ludvig <mludvig@suse.cz>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFC] Re: Proposed fix to gdb for printing 64-bit addresses
Date: Tue, 07 May 2002 10:49:00 -0000	[thread overview]
Message-ID: <3CD813C5.1040108@cygnus.com> (raw)
In-Reply-To: <3CD7F89C.7050407@suse.cz>

> Than there is no need for different handling of 32/64b archs.


Hmm, what interesting timing, note the patch:


http://sources.redhat.com/ml/gdb-patches/2002-05/msg00114.html

in particular:

> There are, I think, several good follow-on patches:
> 
> 	local_address_string{,_custom}()
> 		to handle the address case
> 		Get rid of all those if (TARGET_ADDR_BIT) ... else ...
> 

[I'm not the cli maintainer so it isn't my call]

I suspect it would be better to retain the current behavour - print all 
TARGET_ADDR_BITs of a core address but then let the user override that 
using a ``set ...'' command (like `set output-radix').  If there is a 
``local_address_string()'' function then that is much easier.

Part of the intent of ui_out_field_core_addr() was to address this - 
have one place determining the way that addresses were displayed so that 
it could be changed uniformly across all of GDB.

Andrew


      reply	other threads:[~2002-05-07 17:49 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-29 11:16 Proposed fix to gdb for printing 64-bit addresses on AIX Brian Taylor
2002-05-04 20:08 ` Andrew Cagney
2002-05-07  6:19 ` [RFC] Re: Proposed fix to gdb for printing 64-bit addresses Michal Ludvig
2002-05-07  7:56   ` Daniel Jacobowitz
2002-05-07  8:54     ` Michal Ludvig
2002-05-07 10:49       ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CD813C5.1040108@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=mludvig@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox