From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5061 invoked by alias); 7 May 2002 17:49:54 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5040 invoked from network); 7 May 2002 17:49:51 -0000 Received: from unknown (HELO localhost.redhat.com) (216.138.202.10) by sources.redhat.com with SMTP; 7 May 2002 17:49:51 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 6B0FA3D2B; Tue, 7 May 2002 13:49:57 -0400 (EDT) Message-ID: <3CD813C5.1040108@cygnus.com> Date: Tue, 07 May 2002 10:49:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:1.0rc1) Gecko/20020429 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Michal Ludvig Cc: gdb-patches@sources.redhat.com Subject: Re: [RFC] Re: Proposed fix to gdb for printing 64-bit addresses References: <3CCD8E01.2020500@model.com> <3CD7D446.5020800@suse.cz> <20020507145558.GB17670@nevyn.them.org> <3CD7F89C.7050407@suse.cz> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-05/txt/msg00172.txt.bz2 > Than there is no need for different handling of 32/64b archs. Hmm, what interesting timing, note the patch: http://sources.redhat.com/ml/gdb-patches/2002-05/msg00114.html in particular: > There are, I think, several good follow-on patches: > > local_address_string{,_custom}() > to handle the address case > Get rid of all those if (TARGET_ADDR_BIT) ... else ... > [I'm not the cli maintainer so it isn't my call] I suspect it would be better to retain the current behavour - print all TARGET_ADDR_BITs of a core address but then let the user override that using a ``set ...'' command (like `set output-radix'). If there is a ``local_address_string()'' function then that is much easier. Part of the intent of ui_out_field_core_addr() was to address this - have one place determining the way that addresses were displayed so that it could be changed uniformly across all of GDB. Andrew