[RFA] target.c patch

[RFA] target.c patch

[Ben Elliston]

I noticed a comment about a "trust-readonly" option, yet it is called
"trust-readonly-sections" -- fixed.  Okay to commit?

Ben


2002-04-26  Ben Elliston  <bje@redhat.com>

       * target.c (do_xfer_memory): Correct reference to the new option
       "trust-readonly-sections".

Index: target.c
===================================================================
RCS file: /cvs/src/src/gdb/target.c,v
retrieving revision 1.33
diff -u -r1.33 target.c
--- target.c    1 Feb 2002 01:01:21 -0000       1.33
+++ target.c    26 Apr 2002 21:07:52 -0000
@@ -861,9 +861,9 @@
 
   if (!write && trust_readonly)
     {
-      /* User-settable option, "trust-readonly".  If true, then
-        memory from any SEC_READONLY bfd section may be read
-        directly from the bfd file. */
+      /* User-settable option, "trust-readonly-sections".  If true,
+         then memory from any SEC_READONLY bfd section may be read
+         directly from the bfd file. */
 
       struct section_table *secp;
 

Re: [RFA] target.c patch

[Michael Snyder]

Ben Elliston wrote:
> 
> I noticed a comment about a "trust-readonly" option, yet it is called
> "trust-readonly-sections" -- fixed.  Okay to commit?
> 
> Ben

Yes, please do.  Thanks.
> 
> 2002-04-26  Ben Elliston  <bje@redhat.com>
> 
>        * target.c (do_xfer_memory): Correct reference to the new option
>        "trust-readonly-sections".
> 
> Index: target.c
> ===================================================================
> RCS file: /cvs/src/src/gdb/target.c,v
> retrieving revision 1.33
> diff -u -r1.33 target.c
> --- target.c    1 Feb 2002 01:01:21 -0000       1.33
> +++ target.c    26 Apr 2002 21:07:52 -0000
> @@ -861,9 +861,9 @@
> 
>    if (!write && trust_readonly)
>      {
> -      /* User-settable option, "trust-readonly".  If true, then
> -        memory from any SEC_READONLY bfd section may be read
> -        directly from the bfd file. */
> +      /* User-settable option, "trust-readonly-sections".  If true,
> +         then memory from any SEC_READONLY bfd section may be read
> +         directly from the bfd file. */
> 
>        struct section_table *secp;
>

Re: [RFA] target.c patch

[Andrew Cagney]

> Ben Elliston wrote:
> 
>> 
>> I noticed a comment about a "trust-readonly" option, yet it is called
>> "trust-readonly-sections" -- fixed.  Okay to commit?
>> 
>> Ben
> 
> 
> Yes, please do.  Thanks.

This brings up a general wierdness.  You're mentioned in sim/MAINTAINERS 
but not gdb/MAINTAINERS.

I think I might tweak things so that everyone is mentioned under write 
after approval so that there is no confusion - hopefully people can cope 
with multiple roles :-)

enjoy,
Andrew


>> 2002-04-26  Ben Elliston  <bje@redhat.com>
>> 
>> * target.c (do_xfer_memory): Correct reference to the new option
>> "trust-readonly-sections".
>> 
>> Index: target.c
>> ===================================================================
>> RCS file: /cvs/src/src/gdb/target.c,v
>> retrieving revision 1.33
>> diff -u -r1.33 target.c
>> --- target.c    1 Feb 2002 01:01:21 -0000       1.33
>> +++ target.c    26 Apr 2002 21:07:52 -0000
>> @@ -861,9 +861,9 @@
>> 
>> if (!write && trust_readonly)
>> {
>> -      /* User-settable option, "trust-readonly".  If true, then
>> -        memory from any SEC_READONLY bfd section may be read
>> -        directly from the bfd file. */
>> +      /* User-settable option, "trust-readonly-sections".  If true,
>> +         then memory from any SEC_READONLY bfd section may be read
>> +         directly from the bfd file. */
>> 
>> struct section_table *secp;