[PATCH] Makefile.in: no ,-Werror for thread-db.c

[PATCH] Makefile.in: no ,-Werror for thread-db.c

[Elena Zannoni]

I keep getting warnings for thread-db.c about mismatched types:

/home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_fetch_registers':
/home/ezannoni/uberbaum/src/gdb/thread-db.c:805: warning: passing arg 1 of `supply_fpregset' from incompatible pointer type
/home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_store_registers':
/home/ezannoni/uberbaum/src/gdb/thread-db.c:838: warning: passing arg 1 of `fill_fpregset' from incompatible pointer type
/home/ezannoni/uberbaum/src/gdb/thread-db.c:844: warning: passing arg 2 of pointer to function from incompatible pointer type

Is this OK? ...unless somebody more familiar than me with regsets wants
to go and fix it. :-)

Elena


2002-04-26  Elena Zannoni  <ezannoni@redhat.com>

        * Makefile.in (thread-db.o): This file cannot be built
        with ,-Werror enabled.


Index: Makefile.in
===================================================================
RCS file: /cvs/uberbaum/gdb/Makefile.in,v
retrieving revision 1.179
diff -u -p -r1.179 Makefile.in
--- Makefile.in	25 Apr 2002 20:34:54 -0000	1.179
+++ Makefile.in	26 Apr 2002 20:29:42 -0000
@@ -1896,6 +1896,8 @@ linux-proc.o: linux-proc.c $(defs_h)
 thread-db.o: thread-db.c $(defs_h) gdb_assert.h gdb_proc_service.h \
 	gdb_thread_db.h $(bfd_h) $(gdbthread_h) $(inferior_h) $(symfile_h) \
 	$(objfiles_h) $(target_h) $(regcache_h)
+	$(CC) -c $(INTERNAL_WARN_CFLAGS) $(NO_WERROR_CFLAGS) \
+		$(srcdir)/thread-db.c
 
 lin-lwp.o: lin-lwp.c $(defs_h) gdb_assert.h gdb_wait.h $(gdbthread_h) \
 	$(inferior_h) $(target_h) $(gdbcmd_h) $(regcache_h)

Re: [PATCH] Makefile.in: no ,-Werror for thread-db.c

[Andrew Cagney]

> I keep getting warnings for thread-db.c about mismatched types:
> 
> /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_fetch_registers':
> /home/ezannoni/uberbaum/src/gdb/thread-db.c:805: warning: passing arg 1 of `supply_fpregset' from incompatible pointer type
> /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_store_registers':
> /home/ezannoni/uberbaum/src/gdb/thread-db.c:838: warning: passing arg 1 of `fill_fpregset' from incompatible pointer type
> /home/ezannoni/uberbaum/src/gdb/thread-db.c:844: warning: passing arg 2 of pointer to function from incompatible pointer type
> 
> Is this OK? ...unless somebody more familiar than me with regsets wants
> to go and fix it. :-)

Which host?  It builds on RH 7.2 cleanly.  Does the platform have broken 
headers?

Andrew

Re: [PATCH] Makefile.in: no ,-Werror for thread-db.c

[Elena Zannoni]

Andrew Cagney writes:
 > > I keep getting warnings for thread-db.c about mismatched types:
 > > 
 > > /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_fetch_registers':
 > > /home/ezannoni/uberbaum/src/gdb/thread-db.c:805: warning: passing arg 1 of `supply_fpregset' from incompatible pointer type
 > > /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_store_registers':
 > > /home/ezannoni/uberbaum/src/gdb/thread-db.c:838: warning: passing arg 1 of `fill_fpregset' from incompatible pointer type
 > > /home/ezannoni/uberbaum/src/gdb/thread-db.c:844: warning: passing arg 2 of pointer to function from incompatible pointer type
 > > 
 > > Is this OK? ...unless somebody more familiar than me with regsets wants
 > > to go and fix it. :-)
 > 
 > Which host?  It builds on RH 7.2 cleanly.  Does the platform have broken 
 > headers?
 > 
 > Andrew

ppc G4 with yellowdog linux.
It could be a platform problem, yes.

Elena

Re: [PATCH] Makefile.in: no ,-Werror for thread-db.c

[Daniel Jacobowitz]

On Fri, Apr 26, 2002 at 04:29:46PM -0400, Elena Zannoni wrote:
> 
> I keep getting warnings for thread-db.c about mismatched types:
> 
> /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_fetch_registers':
> /home/ezannoni/uberbaum/src/gdb/thread-db.c:805: warning: passing arg 1 of `supply_fpregset' from incompatible pointer type
> /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_store_registers':
> /home/ezannoni/uberbaum/src/gdb/thread-db.c:838: warning: passing arg 1 of `fill_fpregset' from incompatible pointer type
> /home/ezannoni/uberbaum/src/gdb/thread-db.c:844: warning: passing arg 2 of pointer to function from incompatible pointer type
> 
> Is this OK? ...unless somebody more familiar than me with regsets wants
> to go and fix it. :-)

This implies that your platform (PowerPC you said?) has a broken
prfpregset_t in the presence of AltiVec.  We should both get glibc
fixed and/or autoconf away the problem...

-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [PATCH] Makefile.in: no ,-Werror for thread-db.c

[Michael Snyder]

Elena Zannoni wrote:
> 
> Andrew Cagney writes:
>  > > I keep getting warnings for thread-db.c about mismatched types:
>  > >
>  > > /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_fetch_registers':
>  > > /home/ezannoni/uberbaum/src/gdb/thread-db.c:805: warning: passing arg 1 of `supply_fpregset' from incompatible pointer type
>  > > /home/ezannoni/uberbaum/src/gdb/thread-db.c: In function `thread_db_store_registers':
>  > > /home/ezannoni/uberbaum/src/gdb/thread-db.c:838: warning: passing arg 1 of `fill_fpregset' from incompatible pointer type
>  > > /home/ezannoni/uberbaum/src/gdb/thread-db.c:844: warning: passing arg 2 of pointer to function from incompatible pointer type
>  > >
>  > > Is this OK? ...unless somebody more familiar than me with regsets wants
>  > > to go and fix it. :-)
>  >
>  > Which host?  It builds on RH 7.2 cleanly.  Does the platform have broken
>  > headers?
>  >
>  > Andrew
> 
> ppc G4 with yellowdog linux.
> It could be a platform problem, yes.

Hmmmm... check your system headers, see how "fpregset" is defined.