Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa/rfc:ppc] svr4 and not just ELFOSABI_LINUX for function parsing et.al.
Date: Thu, 25 Apr 2002 21:31:00 -0000	[thread overview]
Message-ID: <3CC8D802.3000502@cygnus.com> (raw)
In-Reply-To: <1020422075910.ZM32309@localhost.localdomain>

[-- Attachment #1: Type: text/plain, Size: 572 bytes --]

> ppc_linux_memory_remove_breakpoint);
>> set_solib_svr4_fetch_link_map_offsets
>> (gdbarch, ppc_linux_svr4_fetch_link_map_offsets);
>> 
>> when svr4_abi.  It certainly improves things (fails went from 136 -> 80) 
>> but I'm not 100% certain if this is correct for all the above - I 
>> suspect it is overkill :-/
> 
> 
> It looks okay to me.  I have no problem with you checking it in.

I did :-)  I chopped it back to fix just the immediate problem.  The 
number of fails went from 136->83.

I'll figure out where those extra three are hiding separatly.

thanks!
Andrew

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 901 bytes --]

2002-04-26  Andrew Cagney  <ac131313@redhat.com>

	* rs6000-tdep.c (rs6000_gdbarch_init): Only set
	convert_from_func_ptr-addr when AIX / PowerOpen.

Index: rs6000-tdep.c
===================================================================
RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v
retrieving revision 1.59
diff -u -r1.59 rs6000-tdep.c
--- rs6000-tdep.c	20 Apr 2002 03:09:28 -0000	1.59
+++ rs6000-tdep.c	26 Apr 2002 04:24:07 -0000
@@ -2746,8 +2746,11 @@
 
       set_gdbarch_frame_init_saved_regs (gdbarch, rs6000_frame_init_saved_regs);
       set_gdbarch_init_extra_frame_info (gdbarch, rs6000_init_extra_frame_info);
-
-      /* Handle RS/6000 function pointers.  */
+    }
+  if (!sysv_abi)
+    {
+      /* Handle RS/6000 function pointers (which are really function
+         descriptors).  */
       set_gdbarch_convert_from_func_ptr_addr (gdbarch,
 	rs6000_convert_from_func_ptr_addr);
     }

      reply	other threads:[~2002-04-26  4:31 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-21 21:29 Andrew Cagney
2002-04-22  0:59 ` Kevin Buettner
2002-04-25 21:31   ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC8D802.3000502@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox