From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 18994 invoked by alias); 26 Apr 2002 04:31:00 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 18986 invoked from network); 26 Apr 2002 04:30:58 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 26 Apr 2002 04:30:58 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 1628C3D06; Fri, 26 Apr 2002 00:30:58 -0400 (EDT) Message-ID: <3CC8D802.3000502@cygnus.com> Date: Thu, 25 Apr 2002 21:31:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020424 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [rfa/rfc:ppc] svr4 and not just ELFOSABI_LINUX for function parsing et.al. References: <3CC391A7.4090607@cygnus.com> <1020422075910.ZM32309@localhost.localdomain> Content-Type: multipart/mixed; boundary="------------030803060906050403020106" X-SW-Source: 2002-04/txt/msg01073.txt.bz2 This is a multi-part message in MIME format. --------------030803060906050403020106 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit Content-length: 572 > ppc_linux_memory_remove_breakpoint); >> set_solib_svr4_fetch_link_map_offsets >> (gdbarch, ppc_linux_svr4_fetch_link_map_offsets); >> >> when svr4_abi. It certainly improves things (fails went from 136 -> 80) >> but I'm not 100% certain if this is correct for all the above - I >> suspect it is overkill :-/ > > > It looks okay to me. I have no problem with you checking it in. I did :-) I chopped it back to fix just the immediate problem. The number of fails went from 136->83. I'll figure out where those extra three are hiding separatly. thanks! Andrew --------------030803060906050403020106 Content-Type: text/plain; name="diffs" Content-Transfer-Encoding: 7bit Content-Disposition: inline; filename="diffs" Content-length: 901 2002-04-26 Andrew Cagney * rs6000-tdep.c (rs6000_gdbarch_init): Only set convert_from_func_ptr-addr when AIX / PowerOpen. Index: rs6000-tdep.c =================================================================== RCS file: /cvs/src/src/gdb/rs6000-tdep.c,v retrieving revision 1.59 diff -u -r1.59 rs6000-tdep.c --- rs6000-tdep.c 20 Apr 2002 03:09:28 -0000 1.59 +++ rs6000-tdep.c 26 Apr 2002 04:24:07 -0000 @@ -2746,8 +2746,11 @@ set_gdbarch_frame_init_saved_regs (gdbarch, rs6000_frame_init_saved_regs); set_gdbarch_init_extra_frame_info (gdbarch, rs6000_init_extra_frame_info); - - /* Handle RS/6000 function pointers. */ + } + if (!sysv_abi) + { + /* Handle RS/6000 function pointers (which are really function + descriptors). */ set_gdbarch_convert_from_func_ptr_addr (gdbarch, rs6000_convert_from_func_ptr_addr); } --------------030803060906050403020106--