Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Michael Snyder <msnyder@redhat.com>
To: Richard.Earnshaw@arm.com
Cc: Michael Snyder <msnyder@cygnus.com>,
	gdb-patches@sources.redhat.com, cagney@redhat.com,
	rearnsha@arm.com
Subject: Re: [RFA] More tweaks to arm_skip_prologue
Date: Wed, 24 Apr 2002 11:47:00 -0000	[thread overview]
Message-ID: <3CC6FAE0.30EDB11A@redhat.com> (raw)
In-Reply-To: <200204240922.KAA26547@cam-mail2.cambridge.arm.com>

Richard Earnshaw wrote:
> 
> > Richard Earnshaw wrote:
> > [...]
> > > This should only ever be "str lr, [sp, #-4]!" (note the writeback).
> >
> > Richard, how's this revised patch?
> >
> > Do you think that, if we detect the str lr, [sp, -4]!
> > we should just return pc + 4 immediately?
> 
> Well, there could be some stack allocation (and maybe some stores to it),
> there might, in theory, be some floating point stacking as well.
> 
> >
> > 2002-04-22  Michael Snyder  <msnyder@redhat.com>
> >
> >       * arm-tdep.c (arm_skip_prologue): Better handling for frameless
> >       functions.  Treat "mov ip, sp" as optional.  Recognize
> >       "str lr, [sp, #-4]".
> 
> Working on the principal that this is better than what we have, I think
> this should go in.  More needs to be done, but I don't think it should
> block this change.

Great, that's what I hoped for.
I will be doing some more work on this code, so if you 
want to continue sending suggestions...    ;-)


  reply	other threads:[~2002-04-24 18:47 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-22 17:05 Michael Snyder
2002-04-23  2:44 ` Richard Earnshaw
2002-04-23 10:54   ` Michael Snyder
2002-04-24  2:16     ` Richard Earnshaw
2002-04-23 16:00   ` Michael Snyder
2002-04-24  2:23     ` Richard Earnshaw
2002-04-24 11:47       ` Michael Snyder [this message]
2002-04-24 14:23       ` Michael Snyder

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC6FAE0.30EDB11A@redhat.com \
    --to=msnyder@redhat.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=cagney@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=msnyder@cygnus.com \
    --cc=rearnsha@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox