From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 21541 invoked by alias); 24 Apr 2002 18:47:22 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 21533 invoked from network); 24 Apr 2002 18:47:19 -0000 Received: from unknown (HELO cygnus.com) (205.180.83.203) by sources.redhat.com with SMTP; 24 Apr 2002 18:47:19 -0000 Received: from redhat.com (reddwarf.sfbay.redhat.com [172.16.24.50]) by runyon.cygnus.com (8.8.7-cygnus/8.8.7) with ESMTP id LAA20684; Wed, 24 Apr 2002 11:47:15 -0700 (PDT) Message-ID: <3CC6FAE0.30EDB11A@redhat.com> Date: Wed, 24 Apr 2002 11:47:00 -0000 From: Michael Snyder Organization: Red Hat, Inc. X-Accept-Language: en MIME-Version: 1.0 To: Richard.Earnshaw@arm.com CC: Michael Snyder , gdb-patches@sources.redhat.com, cagney@redhat.com, rearnsha@arm.com Subject: Re: [RFA] More tweaks to arm_skip_prologue References: <200204240922.KAA26547@cam-mail2.cambridge.arm.com> Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00963.txt.bz2 Richard Earnshaw wrote: > > > Richard Earnshaw wrote: > > [...] > > > This should only ever be "str lr, [sp, #-4]!" (note the writeback). > > > > Richard, how's this revised patch? > > > > Do you think that, if we detect the str lr, [sp, -4]! > > we should just return pc + 4 immediately? > > Well, there could be some stack allocation (and maybe some stores to it), > there might, in theory, be some floating point stacking as well. > > > > > 2002-04-22 Michael Snyder > > > > * arm-tdep.c (arm_skip_prologue): Better handling for frameless > > functions. Treat "mov ip, sp" as optional. Recognize > > "str lr, [sp, #-4]". > > Working on the principal that this is better than what we have, I think > this should go in. More needs to be done, but I don't think it should > block this change. Great, that's what I hoped for. I will be doing some more work on this code, so if you want to continue sending suggestions... ;-)