From: Andrew Cagney <ac131313@cygnus.com>
To: "David S. Miller" <davem@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [RFA] Kill SKIP_PROLOGUE_FRAMELESS_P
Date: Sun, 21 Apr 2002 11:40:00 -0000 [thread overview]
Message-ID: <3CC3078D.8010403@cygnus.com> (raw)
In-Reply-To: <20020421.020750.82982361.davem@redhat.com>
> This is being done so that we don't have to multi-arch it.
> It's existence is questionable at best.
Good catch.
I don't think anyone expects SKIP_PROLOGUE_FRAMELESS_P to be
multi-arched. Instead, as the tm.h files (or entire architectures -
arc) get deleted, all uses will disappear. That letting the macro slip
quietly off the table.
Giving the occasional macro a good swift shove never hurts.
> Basically, it allowed a target to optimize SKIP_PROLOGUE()
> if we just cared about whether the function was frameless or
> not (ie. lacked any prologue at all).
>
> PROLOGUE_FRAMELESS_P and it's gdbarch equivalent exist and allow
> the target to perform this optimization equivalently.
>
> So we kill SKIP_PROLOGUE_FRAMELESS_P, and for every target that
> provided it we instead make them implement PROLOGUE_FRAMELESS_P.
>
> Now we have one less thing to make multi-arch'able.
As the patch stands, it is dependant on other changes. Can you please
revise this patch so that it is against the existing source base. That
would create an arc_... and sparc_... function, but leave the
sparc_linux_.. function for later.
enjoy,
Andrew
next prev parent reply other threads:[~2002-04-21 18:40 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-21 2:16 David S. Miller
2002-04-21 11:40 ` Andrew Cagney [this message]
2002-04-21 17:27 ` David S. Miller
2002-04-21 17:51 ` David S. Miller
2002-04-21 18:34 ` Andrew Cagney
2002-04-21 18:40 ` David S. Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CC3078D.8010403@cygnus.com \
--to=ac131313@cygnus.com \
--cc=davem@redhat.com \
--cc=gdb-patches@sources.redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox