From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 17155 invoked by alias); 21 Apr 2002 18:40:30 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 17143 invoked from network); 21 Apr 2002 18:40:29 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 21 Apr 2002 18:40:29 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 972233D1A; Sun, 21 Apr 2002 14:40:13 -0400 (EDT) Message-ID: <3CC3078D.8010403@cygnus.com> Date: Sun, 21 Apr 2002 11:40:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: "David S. Miller" Cc: gdb-patches@sources.redhat.com Subject: Re: [RFA] Kill SKIP_PROLOGUE_FRAMELESS_P References: <20020421.020750.82982361.davem@redhat.com> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00734.txt.bz2 > This is being done so that we don't have to multi-arch it. > It's existence is questionable at best. Good catch. I don't think anyone expects SKIP_PROLOGUE_FRAMELESS_P to be multi-arched. Instead, as the tm.h files (or entire architectures - arc) get deleted, all uses will disappear. That letting the macro slip quietly off the table. Giving the occasional macro a good swift shove never hurts. > Basically, it allowed a target to optimize SKIP_PROLOGUE() > if we just cared about whether the function was frameless or > not (ie. lacked any prologue at all). > > PROLOGUE_FRAMELESS_P and it's gdbarch equivalent exist and allow > the target to perform this optimization equivalently. > > So we kill SKIP_PROLOGUE_FRAMELESS_P, and for every target that > provided it we instead make them implement PROLOGUE_FRAMELESS_P. > > Now we have one less thing to make multi-arch'able. As the patch stands, it is dependant on other changes. Can you please revise this patch so that it is against the existing source base. That would create an arc_... and sparc_... function, but leave the sparc_linux_.. function for later. enjoy, Andrew