Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: thorpej@wasabisystems.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Fix busted logic in find_saved_register()
Date: Sat, 20 Apr 2002 22:35:00 -0000	[thread overview]
Message-ID: <3CC24F97.1040704@cygnus.com> (raw)
In-Reply-To: <20020420185456.Z1627@dr-evil.shagadelic.org>

> On Sat, Apr 20, 2002 at 08:00:06PM -0400, Andrew Cagney wrote:
> 
>  > > Directly.  The alpha_get_saved_register() is nearly identical to the
>  > > mips_get_saved_register().
>  > > If you've implemented INIT_SAVED_REGS() do you need a custom 
>  > get_saved_register()?
> 
> Ok, this is where my understanding of the call_dummy stuff starts to get
> muddled :-)
> 
> The Alpha target doesn't use the generic call_dummy frame stuff, but
> rather its own.  I suspect it could be converted to use the generic
> stuff, but an explanation of how it's supposed to work would really help :-)

Traditional dummy frames were implemented by creating a fake frame on 
the stack that contained all the registers.

Generic dummy frames instead, don't bother.  They create a fake, local 
to gdb, frame that contains the saved registers, and then calls the 
inferior function directly.  On the stack they appear like a special 
frameless function.  On paper, getting them to work is fairly easy.  See 
xstormy16-elf, cris-elf, or any new/obscure target.  Suggest grepping 
for the word ``dummy'' and copying the corresponding settings.

> Would it be terribly evil to commit the alpha multi-arch stuff that I
> have now (which would meet your condition for committing my alpha-netbsd
> configuration :-), and then take a stab at converting it to generic dummy
> frames?

Getting it multi-arched has a higher priority.

Andrew


      reply	other threads:[~2002-04-21  5:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-20 14:48 Jason R Thorpe
2002-04-20 16:08 ` Andrew Cagney
2002-04-20 16:26   ` Jason R Thorpe
2002-04-20 17:00     ` Andrew Cagney
2002-04-20 18:54       ` Jason R Thorpe
2002-04-20 22:35         ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CC24F97.1040704@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=thorpej@wasabisystems.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox