From: Andrew Cagney <ac131313@cygnus.com>
To: thorpej@wasabisystems.com
Cc: gdb-patches@sources.redhat.com
Subject: Re: [PATCH/RFA] Fix busted logic in find_saved_register()
Date: Sat, 20 Apr 2002 16:08:00 -0000 [thread overview]
Message-ID: <3CC1F4D3.9020104@cygnus.com> (raw)
In-Reply-To: <20020420144817.W1627@dr-evil.shagadelic.org>
> find_saved_register() is used by mips_get_saved_register() and
> the alpha_get_saved_register() in my (updated) multi-arch changes
> for the Alpha target.
>
> While investigating some testsuite failures, it appeared that
> there is no way thjat find_saved_register() could possibly work
> on either MIPS or Alpha, since the first thing it does on either
> of those platforms is dereference a NULL pointer (said pointer is
> initlaized to NULL at the top of the function).
>
> I believe the following patch makes find_saved_register() actually
> implement the logic it claims to. It certainly fixes the problem
> I had with GDB dumping core, and fixes the relevant testsuite failures.
>
> OK to commit?
>
> * frame.c (find_saved_register): Avoid a NULL pointer
> dereference and actually walk the frame list.
Yes. Looks like my:
2002-04-17 Andrew Cagney <ac131313@redhat.com>
* frame.c (find_saved_register): Find saved registers in the next
not prev frame.
Fix PR gdb/365.
flushed out another problem.
You mention that the alpha is calling that function. Is that directly
or indirectly? I'm going to eliminate the MIPS direct call.
Andrew
next prev parent reply other threads:[~2002-04-20 23:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-20 14:48 Jason R Thorpe
2002-04-20 16:08 ` Andrew Cagney [this message]
2002-04-20 16:26 ` Jason R Thorpe
2002-04-20 17:00 ` Andrew Cagney
2002-04-20 18:54 ` Jason R Thorpe
2002-04-20 22:35 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CC1F4D3.9020104@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=thorpej@wasabisystems.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox