Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* [RFA] Kill sparc-nat.c compile warning
@ 2002-04-19 22:10 David S. Miller
  2002-04-20 22:17 ` Andrew Cagney
  0 siblings, 1 reply; 3+ messages in thread
From: David S. Miller @ 2002-04-19 22:10 UTC (permalink / raw)
  To: gdb-patches


Pretty straightforward, fix an ambiguous else warning.

2002-04-19  David S. Miller  <davem@redhat.com>

	* sparc-nat.c (store-inferior_registers): Fix ambiguous else.

--- sparc-nat.c.~1~	Wed Mar 20 18:03:13 2002
+++ sparc-nat.c	Fri Apr 19 22:05:47 2002
@@ -155,21 +155,23 @@ store_inferior_registers (int regno)
   /* First decide which pieces of machine-state we need to modify.  
      Default for regno == -1 case is all pieces.  */
   if (regno >= 0)
-    if (FP0_REGNUM <= regno && regno < FP0_REGNUM + 32)
-      {
-	wanna_store = FP_REGS;
-      }
-    else
-      {
-	if (regno == SP_REGNUM)
-	  wanna_store = INT_REGS + STACK_REGS;
-	else if (regno < L0_REGNUM || regno > I7_REGNUM)
-	  wanna_store = INT_REGS;
-	else if (regno == FPS_REGNUM)
+    {
+      if (FP0_REGNUM <= regno && regno < FP0_REGNUM + 32)
+	{
 	  wanna_store = FP_REGS;
-	else
-	  wanna_store = STACK_REGS;
-      }
+	}
+      else
+	{
+	  if (regno == SP_REGNUM)
+	    wanna_store = INT_REGS + STACK_REGS;
+	  else if (regno < L0_REGNUM || regno > I7_REGNUM)
+	    wanna_store = INT_REGS;
+	  else if (regno == FPS_REGNUM)
+	    wanna_store = FP_REGS;
+	  else
+	    wanna_store = STACK_REGS;
+	}
+    }
 
   /* See if we're forcing the stores to happen now, or deferring. */
   if (regno == -2)


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Kill sparc-nat.c compile warning
  2002-04-19 22:10 [RFA] Kill sparc-nat.c compile warning David S. Miller
@ 2002-04-20 22:17 ` Andrew Cagney
  2002-04-20 22:34   ` David S. Miller
  0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2002-04-20 22:17 UTC (permalink / raw)
  To: David S. Miller; +Cc: gdb-patches

> 2002-04-19  David S. Miller  <davem@redhat.com>
> 
> * sparc-nat.c (store-inferior_registers): Fix ambiguous else.
> 

Yes ok.  (btw, sometimes a context diff is easier to read)
Indentation changes are covered by the obvious fix rule.

Andrew


^ permalink raw reply	[flat|nested] 3+ messages in thread

* Re: [RFA] Kill sparc-nat.c compile warning
  2002-04-20 22:17 ` Andrew Cagney
@ 2002-04-20 22:34   ` David S. Miller
  0 siblings, 0 replies; 3+ messages in thread
From: David S. Miller @ 2002-04-20 22:34 UTC (permalink / raw)
  To: ac131313; +Cc: gdb-patches

   From: Andrew Cagney <ac131313@cygnus.com>
   Date: Sun, 21 Apr 2002 01:16:56 -0400

   > 2002-04-19  David S. Miller  <davem@redhat.com>
   > 
   > * sparc-nat.c (store-inferior_registers): Fix ambiguous else.
   
   Yes ok.  (btw, sometimes a context diff is easier to read)

Ok, installed.

   Indentation changes are covered by the obvious fix rule.
   
Noted.


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2002-04-21  5:34 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-19 22:10 [RFA] Kill sparc-nat.c compile warning David S. Miller
2002-04-20 22:17 ` Andrew Cagney
2002-04-20 22:34   ` David S. Miller

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox