From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [patch/rfa:rs6000] Don't use ->prev
Date: Fri, 19 Apr 2002 20:11:00 -0000 [thread overview]
Message-ID: <3CC0DC5C.3040506@cygnus.com> (raw)
In-Reply-To: <1020415075921.ZM24483@localhost.localdomain>
> * rs6000-tdep.c (frame_get_saved_regs): Use rs6000_frame_chain()
>> instead of ->prev.
>
>
> I think that your patch is okay so long as you use FRAME_CHAIN()
> instead of rs6000_frame_chain(). Note that FRAME_CHAIN() may be set
> to something other than rs6000_frame_chain() depending upon the ABI / OS.
Ah, good catch, I've made the adjustment. Thanks.
> At the moment though, it doesn't really matter too much since the
> case -- signal handler trampolines -- that calling FRAME_CHAIN gets
> right is broken in frame_get_saved_regs() anyway. The Linux/PPC
> target works around this deficiency by interposing some code which
> computes the correct saved register locations for signal handler
> callers instead of calling the rs6000_* version which invokes
> rs6000_get_saved_register().
:-)
> 2002-04-14 Andrew Cagney <ac131313@redhat.com>
>
> * sparc-tdep.c (sparc_get_saved_register): Use get_prev_frame
> instead of ->prev.
> * z8k-tdep.c (z8k_frame_chain): Do not use ->prev.
> * s390-tdep.c (s390_frame_chain): Do not use ->prev.
> * rs6000-tdep.c (frame_get_saved_regs): Use rs6000_frame_chain()
> instead of ->prev.
>
I've checked this in.
Andrew
next prev parent reply other threads:[~2002-04-20 3:11 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2002-04-14 9:52 Andrew Cagney
2002-04-15 0:59 ` Kevin Buettner
2002-04-19 20:11 ` Andrew Cagney [this message]
2002-04-24 15:09 ` Michael Snyder
2002-05-04 18:39 ` Andrew Cagney
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3CC0DC5C.3040506@cygnus.com \
--to=ac131313@cygnus.com \
--cc=gdb-patches@sources.redhat.com \
--cc=kevinb@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox