From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 5888 invoked by alias); 20 Apr 2002 03:11:33 -0000 Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm Precedence: bulk List-Subscribe: List-Archive: List-Post: List-Help: , Sender: gdb-patches-owner@sources.redhat.com Received: (qmail 5877 invoked from network); 20 Apr 2002 03:11:30 -0000 Received: from unknown (HELO localhost.redhat.com) (24.112.240.27) by sources.redhat.com with SMTP; 20 Apr 2002 03:11:30 -0000 Received: from cygnus.com (localhost [127.0.0.1]) by localhost.redhat.com (Postfix) with ESMTP id 2915D3D1A; Fri, 19 Apr 2002 23:11:25 -0400 (EDT) Message-ID: <3CC0DC5C.3040506@cygnus.com> Date: Fri, 19 Apr 2002 20:11:00 -0000 From: Andrew Cagney User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328 X-Accept-Language: en-us, en MIME-Version: 1.0 To: Kevin Buettner Cc: gdb-patches@sources.redhat.com Subject: Re: [patch/rfa:rs6000] Don't use ->prev References: <3CB9B3B1.90007@cygnus.com> <1020415075921.ZM24483@localhost.localdomain> Content-Type: text/plain; charset=us-ascii; format=flowed Content-Transfer-Encoding: 7bit X-SW-Source: 2002-04/txt/msg00668.txt.bz2 > * rs6000-tdep.c (frame_get_saved_regs): Use rs6000_frame_chain() >> instead of ->prev. > > > I think that your patch is okay so long as you use FRAME_CHAIN() > instead of rs6000_frame_chain(). Note that FRAME_CHAIN() may be set > to something other than rs6000_frame_chain() depending upon the ABI / OS. Ah, good catch, I've made the adjustment. Thanks. > At the moment though, it doesn't really matter too much since the > case -- signal handler trampolines -- that calling FRAME_CHAIN gets > right is broken in frame_get_saved_regs() anyway. The Linux/PPC > target works around this deficiency by interposing some code which > computes the correct saved register locations for signal handler > callers instead of calling the rs6000_* version which invokes > rs6000_get_saved_register(). :-) > 2002-04-14 Andrew Cagney > > * sparc-tdep.c (sparc_get_saved_register): Use get_prev_frame > instead of ->prev. > * z8k-tdep.c (z8k_frame_chain): Do not use ->prev. > * s390-tdep.c (s390_frame_chain): Do not use ->prev. > * rs6000-tdep.c (frame_get_saved_regs): Use rs6000_frame_chain() > instead of ->prev. > I've checked this in. Andrew