Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
* PATCH to dejagnu/lib/remote.exp:check_for_board_status
@ 2002-02-28  3:09 Jason Merrill
  2002-04-14 14:06 ` Jason Merrill
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Merrill @ 2002-02-28  3:09 UTC (permalink / raw)
  To: gdb-patches; +Cc: Jason Merrill

[-- Attachment #1: Type: text/plain, Size: 431 bytes --]

The status wrapper adds "<EOL>*** EXIT code n<EOL>" to the output.
check_for_board_status tries to strip this, but the old regexp would only
strip a CR or an LF, not both, so we were left with a trailing CR if the
target uses the DOS EOL convention.  Fixed thus.

OK?

2002-02-28  Jason Merrill  <jason@redhat.com>

	* lib/remote.exp (check_for_board_status): Remove both CR and LF
	at the beginning of the status wrapper output.


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 928 bytes --]

*** remote.exp.~1~	Thu Feb 28 10:44:49 2002
--- remote.exp	Thu Feb 28 02:31:07 2002
*************** proc check_for_board_status  { variable 
*** 1057,1063 ****
      if [regexp "(^|\[\r\n\])\\*\\*\\* EXIT code" $output] {
  	regsub "^.*\\*\\*\\* EXIT code " $output "" result;
  	regsub "\[\r\n\].*$" $result "" result;
! 	regsub -all "(^|\[\r\n\])\\*\\*\\* EXIT code \[^\r\n\]*(\[\r\n\]\[\r\n\]?|$)" $output "" output;
  	regsub "^\[^0-9\]*" $result "" result
  	regsub "\[^0-9\]*$" $result "" result
  	verbose "got board status $result" 3
--- 1057,1063 ----
      if [regexp "(^|\[\r\n\])\\*\\*\\* EXIT code" $output] {
  	regsub "^.*\\*\\*\\* EXIT code " $output "" result;
  	regsub "\[\r\n\].*$" $result "" result;
! 	regsub -all "(^|\r?\n)\\*\\*\\* EXIT code \[^\r\n\]*(\r?\n|$)" $output "" output;
  	regsub "^\[^0-9\]*" $result "" result
  	regsub "\[^0-9\]*$" $result "" result
  	verbose "got board status $result" 3

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH to dejagnu/lib/remote.exp:check_for_board_status
  2002-02-28  3:09 PATCH to dejagnu/lib/remote.exp:check_for_board_status Jason Merrill
@ 2002-04-14 14:06 ` Jason Merrill
  2002-04-14 14:24   ` Andrew Cagney
  0 siblings, 1 reply; 4+ messages in thread
From: Jason Merrill @ 2002-04-14 14:06 UTC (permalink / raw)
  To: gdb-patches

It's been a month and a half; I'm checking this in.

Jason


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH to dejagnu/lib/remote.exp:check_for_board_status
  2002-04-14 14:06 ` Jason Merrill
@ 2002-04-14 14:24   ` Andrew Cagney
  2002-04-14 14:31     ` Jason Merrill
  0 siblings, 1 reply; 4+ messages in thread
From: Andrew Cagney @ 2002-04-14 14:24 UTC (permalink / raw)
  To: Jason Merrill; +Cc: gdb-patches

> It's been a month and a half; I'm checking this in.

The outstanding dejagnu patches haven't been lost - they are sitting in 
my stalled tray.

Looking at the actual change though, I don't think anyone is going to 
notice.  Did you push it up-stream to the official deajgnu sources?

Andrew


^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: PATCH to dejagnu/lib/remote.exp:check_for_board_status
  2002-04-14 14:24   ` Andrew Cagney
@ 2002-04-14 14:31     ` Jason Merrill
  0 siblings, 0 replies; 4+ messages in thread
From: Jason Merrill @ 2002-04-14 14:31 UTC (permalink / raw)
  To: Andrew Cagney; +Cc: gdb-patches

>>>>> "Andrew" == Andrew Cagney <ac131313@cygnus.com> writes:

> Looking at the actual change though, I don't think anyone is going to
> notice.  Did you push it up-stream to the official deajgnu sources?

Just sent it on, thanks.

Jason


^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2002-04-14 21:31 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-02-28  3:09 PATCH to dejagnu/lib/remote.exp:check_for_board_status Jason Merrill
2002-04-14 14:06 ` Jason Merrill
2002-04-14 14:24   ` Andrew Cagney
2002-04-14 14:31     ` Jason Merrill

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox