* PATCH: Squash some more gdbserver warnings on non-i386
@ 2002-04-09 15:58 Daniel Jacobowitz
2002-04-09 16:04 ` Andrew Cagney
0 siblings, 1 reply; 3+ messages in thread
From: Daniel Jacobowitz @ 2002-04-09 15:58 UTC (permalink / raw)
To: gdb-patches
Some platforms pull in <string.h> from <stdlib.h>, some don't. Also fix the
missing "gdbserver/" prefixes in my last ChangeLog entry. Committed as
obvious.
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
2002-04-09 Daniel Jacobowitz <drow@mvista.com>
* gdbserver/server.h: Include <string.h> if HAVE_STRING_H.
* ChangeLog: Correct paths in last ChangeLog entry.
Index: server.h
===================================================================
RCS file: /cvs/src/src/gdb/gdbserver/server.h,v
retrieving revision 1.7
diff -u -p -r1.7 server.h
--- server.h 9 Apr 2002 21:16:16 -0000 1.7
+++ server.h 9 Apr 2002 22:48:27 -0000
@@ -30,6 +30,10 @@
#include <errno.h>
#include <setjmp.h>
+#ifdef HAVE_STRING_H
+#include <string.h>
+#endif
+
#ifndef ATTR_NORETURN
#if defined(__GNUC__) && (__GNUC__ > 2 || (__GNUC__ == 2 && __GNUC_MINOR__ >= 7))
#define ATTR_NORETURN __attribute__ ((noreturn))
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Squash some more gdbserver warnings on non-i386
2002-04-09 15:58 PATCH: Squash some more gdbserver warnings on non-i386 Daniel Jacobowitz
@ 2002-04-09 16:04 ` Andrew Cagney
2002-04-09 16:11 ` Daniel Jacobowitz
0 siblings, 1 reply; 3+ messages in thread
From: Andrew Cagney @ 2002-04-09 16:04 UTC (permalink / raw)
To: Daniel Jacobowitz; +Cc: gdb-patches
> +#ifdef HAVE_STRING_H
> +#include <string.h>
> +#endif
> +
Suggest
#include "gdb_string.h"
Andrew
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: PATCH: Squash some more gdbserver warnings on non-i386
2002-04-09 16:04 ` Andrew Cagney
@ 2002-04-09 16:11 ` Daniel Jacobowitz
0 siblings, 0 replies; 3+ messages in thread
From: Daniel Jacobowitz @ 2002-04-09 16:11 UTC (permalink / raw)
To: Andrew Cagney; +Cc: gdb-patches
On Tue, Apr 09, 2002 at 07:04:45PM -0400, Andrew Cagney wrote:
> >+#ifdef HAVE_STRING_H
> >+#include <string.h>
> >+#endif
> >+
>
> Suggest
> #include "gdb_string.h"
Hmm. It isn't available in gdbserver, and I'm reluctant to share any
header which checks autoconf-set variables. gdbserver doesn't have a
lot of what gdb_string.h is checking in its "config.h". It sure is a
handy looking file, though...
--
Daniel Jacobowitz Carnegie Mellon University
MontaVista Software Debian GNU/Linux Developer
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2002-04-09 23:11 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2002-04-09 15:58 PATCH: Squash some more gdbserver warnings on non-i386 Daniel Jacobowitz
2002-04-09 16:04 ` Andrew Cagney
2002-04-09 16:11 ` Daniel Jacobowitz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox