Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:sparc] Remove write_fp() from sparc-tdep.c
Date: Fri, 05 Apr 2002 16:05:00 -0000	[thread overview]
Message-ID: <3CAE3BCC.50001@cygnus.com> (raw)
In-Reply-To: <1020406000239.ZM2218@localhost.localdomain>

> On Apr 5,  5:04pm, Andrew Cagney wrote:
> 
> 
>> if (strcmp (target_shortname, "sim") != 0)
>> {
>> -      write_fp (old_sp);
>> -
>> +      if (gdbarch_tdep (current_gdbarch)->intreg_size == 8)
> 
> 
> How about
> 
> 	 if (GDB_TARGET_IS_SPARC64)

Didn't see it, I'll tweak it.

> instead?  (That matches the existing convention in the rest of the
> file better.)
> 
> Aside from that, I think your change is fine.  Something to consider
> though is whether the entire
> 
>     if (strcmp (target_shortname, "sim") != 0)
>       {
>         ...
>       }
> 
> could simply go away.  I.e, let the "sim" case just use the non-sim
> code.

Somebody elses problem - the only objective of this patch was to remove 
write_fp() :-)

thanks,
Andrew



      reply	other threads:[~2002-04-06  0:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-05 14:04 Andrew Cagney
2002-04-05 14:38 ` Michael Snyder
2002-04-05 15:01   ` Andrew Cagney
2002-04-05 16:03 ` Kevin Buettner
2002-04-05 16:05   ` Andrew Cagney [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CAE3BCC.50001@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=gdb-patches@sources.redhat.com \
    --cc=kevinb@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox