From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gdb-patches-return-13978-listarch-gdb-patches=sourceware.cygnus.com@sources.redhat.com>
Received: (qmail 14809 invoked by alias); 6 Apr 2002 00:05:34 -0000
Mailing-List: contact gdb-patches-help@sources.redhat.com; run by ezmlm
Precedence: bulk
List-Subscribe: <mailto:gdb-patches-subscribe@sources.redhat.com>
List-Archive: <http://sources.redhat.com/ml/gdb-patches/>
List-Post: <mailto:gdb-patches@sources.redhat.com>
List-Help: <mailto:gdb-patches-help@sources.redhat.com>, <http://sources.redhat.com/ml/#faqs>
Sender: gdb-patches-owner@sources.redhat.com
Received: (qmail 14795 invoked from network); 6 Apr 2002 00:05:33 -0000
Received: from unknown (HELO localhost.redhat.com) (216.138.202.10)
  by sources.redhat.com with SMTP; 6 Apr 2002 00:05:33 -0000
Received: from cygnus.com (localhost [127.0.0.1])
	by localhost.redhat.com (Postfix) with ESMTP
	id 5EF1B3C9F; Fri,  5 Apr 2002 19:05:32 -0500 (EST)
Message-ID: <3CAE3BCC.50001@cygnus.com>
Date: Fri, 05 Apr 2002 16:05:00 -0000
From: Andrew Cagney <ac131313@cygnus.com>
User-Agent: Mozilla/5.0 (X11; U; NetBSD macppc; en-US; rv:0.9.9) Gecko/20020328
X-Accept-Language: en-us, en
MIME-Version: 1.0
To: Kevin Buettner <kevinb@redhat.com>
Cc: gdb-patches@sources.redhat.com
Subject: Re: [rfa:sparc] Remove write_fp() from sparc-tdep.c
References: <3CAE1F58.4070601@cygnus.com> <1020406000239.ZM2218@localhost.localdomain>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
X-SW-Source: 2002-04/txt/msg00199.txt.bz2

> On Apr 5,  5:04pm, Andrew Cagney wrote:
> 
> 
>> if (strcmp (target_shortname, "sim") != 0)
>> {
>> -      write_fp (old_sp);
>> -
>> +      if (gdbarch_tdep (current_gdbarch)->intreg_size == 8)
> 
> 
> How about
> 
> 	 if (GDB_TARGET_IS_SPARC64)

Didn't see it, I'll tweak it.

> instead?  (That matches the existing convention in the rest of the
> file better.)
> 
> Aside from that, I think your change is fine.  Something to consider
> though is whether the entire
> 
>     if (strcmp (target_shortname, "sim") != 0)
>       {
>         ...
>       }
> 
> could simply go away.  I.e, let the "sim" case just use the non-sim
> code.

Somebody elses problem - the only objective of this patch was to remove 
write_fp() :-)

thanks,
Andrew