Mirror of the gdb-patches mailing list
 help / color / mirror / Atom feed
From: Andrew Cagney <ac131313@cygnus.com>
To: Fernando Nasser <fnasser@redhat.com>
Cc: Daniel Jacobowitz <drow@mvista.com>, gdb-patches@sources.redhat.com
Subject: Re: [RFA/mi-testsuite] XFAIL mi*-console.exp
Date: Fri, 05 Apr 2002 06:49:00 -0000	[thread overview]
Message-ID: <3CADB974.8090605@cygnus.com> (raw)
In-Reply-To: <3CACF57B.B55F03E4@redhat.com>

> Andrew Cagney wrote:
> 
>> 
> 
>> > On Wed, Apr 03, 2002 at 11:27:13PM -0500, Andrew Cagney wrote:
>> >
> 
>> >> >These tests are testing for a feature that exists either nowhere or just in
>> >> >simulators and some remote stubs: that the inferior's output goes through
>> >> >GDB and is properly encoded by the MI layer.  Since support isn't there for
>> >> >many remote debugging stubs or for native, I think these two tests should
>> >> >be
>> >> >XFAIL'd.  Does that make sense, Andrew?  If so, OK to commit this?
> 
>> >
> 
>> >>
>> >> I believe GDB's rule for XFAIL is something that can't work (due to an
>> >> external constraint) rather than doesn't work (due to a lack of code).
>> >>
>> >> Hence it was marked as a known bug rather than a limitation.
> 
>> >
>> >
>> > OK, so it isn't an XFAIL.  I don't think FAIL is really appropriate
>> > either; tests which test a not-yet-implemented feature (and one that I
>> > think is a bad idea, for native targets, to be honest) don't add any
>> > information by failing.  UNSUPPORTED perhaps?  Or just not running the
>> > test in native setups, for now?
> 
>> Er, actually, XFAIL might be closer to the truth than UNSUPPORTED.
>> Although neither indicate UNIMPLEMENTED.
>> 
> 
> 
> I see. It is not UNSUPPORTED because the environment have it, just some
> gsb stubs (and native) do not handle it (i.e., our fault).
> 
> Well, as we don't have UNIMPLEMENTED, we are left with only 2 options:
> 
> I guess we would use XFAIL if we decide that this is a feature that
> we should have and not having it is a failure that should be fixed.

> Otherwise we can just skip the test where it can't run.

I don't think this one is an option.  The gdb.asm test was being skipped 
and as a consequence everyone ignored it.  Now that it fails, people are 
fixing it.

Given it is a GDB ``bug'', is the correct approach:

	set prms_id <i-can't-find-it>
	FAIL ...

Andrew


  reply	other threads:[~2002-04-05 14:49 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2002-04-02 16:42 Daniel Jacobowitz
2002-04-02 16:52 ` Michael Snyder
2002-04-02 17:01   ` Daniel Jacobowitz
2002-04-02 17:22     ` Michael Snyder
2002-04-02 17:39       ` Daniel Jacobowitz
2002-04-03  6:14         ` Fernando Nasser
2002-04-04  7:15           ` Fernando Nasser
2002-04-04  8:36             ` Daniel Jacobowitz
2002-04-04 11:09             ` Andrew Cagney
2002-04-03 20:27 ` Andrew Cagney
2002-04-03 21:13   ` Daniel Jacobowitz
2002-04-04 13:49     ` Andrew Cagney
2002-04-04 13:53       ` Daniel Jacobowitz
2002-04-06 15:04         ` Andrew Cagney
2002-04-04 16:55       ` Fernando Nasser
2002-04-05  6:49         ` Andrew Cagney [this message]
2002-04-05  7:22           ` Fernando Nasser
2002-04-05  7:23 Michael Elizabeth Chastain

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=3CADB974.8090605@cygnus.com \
    --to=ac131313@cygnus.com \
    --cc=drow@mvista.com \
    --cc=fnasser@redhat.com \
    --cc=gdb-patches@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox