[patch] ``struct value'' cleanups

[patch] ``struct value'' cleanups

[Andrew Cagney]

[-- Attachment #1: Type: text/plain, Size: 217 bytes --]

Hello,

The attatched are some simple cleanups for ``struct value''.  Committed.

Andrew

PS: As far as I can tell, the unused bit of code was added '94 and from 
day one it included the comment ``when is this used'.

[-- Attachment #2: diffs --]
[-- Type: text/plain, Size: 1201 bytes --]

2002-03-16  Andrew Cagney  <ac131313@redhat.com>

	* value.h (struct value): Delete field ``substring_addr''.  Change
	aligner fields to force_doublest_align, force_longest_align,
	force_core_addr_align and force_pointer_align.

Index: value.h
===================================================================
RCS file: /cvs/src/src/gdb/value.h,v
retrieving revision 1.27
diff -u -r1.27 value.h
--- value.h	2002/03/16 02:57:42	1.27
+++ value.h	2002/03/17 00:52:51
@@ -125,14 +125,6 @@
        list.  */
     struct value *next;
 
-    /* ??? When is this used?  */
-    union
-      {
-	CORE_ADDR memaddr;
-	char *myaddr;
-      }
-    substring_addr;
-
     /* Register number if the value is from a register.  Is not kept
        if you take a field of a structure that is stored in a
        register.  Shouldn't it be?  */
@@ -166,9 +158,10 @@
     union
       {
 	long contents[1];
-	double force_double_align;
-	LONGEST force_longlong_align;
-	char *literal_data;
+	DOUBLEST force_doublest_align;
+	LONGEST force_longest_align;
+	CORE_ADDR force_core_addr_align;
+	void *force_pointer_aligh;
       }
     aligner;
     /* Do not add any new members here -- contents above will trash them */

Re: [patch] ``struct value'' cleanups

[Daniel Jacobowitz]

On Sat, Mar 16, 2002 at 08:04:18PM -0500, Andrew Cagney wrote:
> @@ -166,9 +158,10 @@
>      union
>        {
>  	long contents[1];
> -	double force_double_align;
> -	LONGEST force_longlong_align;
> -	char *literal_data;
> +	DOUBLEST force_doublest_align;
> +	LONGEST force_longest_align;
> +	CORE_ADDR force_core_addr_align;
> +	void *force_pointer_aligh;
>        }
>      aligner;
>      /* Do not add any new members here -- contents above will trash them */

(I suppose literal_data was not actually used anywhere either?  It
seems different than the other members...)

Typo, force_pointer_aligh.
                        ^


-- 
Daniel Jacobowitz                           Carnegie Mellon University
MontaVista Software                         Debian GNU/Linux Developer

Re: [patch] ``struct value'' cleanups

[Andrew Cagney]

> On Sat, Mar 16, 2002 at 08:04:18PM -0500, Andrew Cagney wrote:
> 
>> @@ -166,9 +158,10 @@
>> union
>> {
>> long contents[1];
>> -	double force_double_align;
>> -	LONGEST force_longlong_align;
>> -	char *literal_data;
>> +	DOUBLEST force_doublest_align;
>> +	LONGEST force_longest_align;
>> +	CORE_ADDR force_core_addr_align;
>> +	void *force_pointer_aligh;
>> }
>> aligner;
>> /* Do not add any new members here -- contents above will trash them */
> 
> 
> (I suppose literal_data was not actually used anywhere either?  It
> seems different than the other members...)

Rebuilt after the change and a grep didn't show anything.

> Typo, force_pointer_aligh.

I'm tempted to leave it in just to see if it also manages to remain 
there for 8 years :-) (thanks)

Andrew